From 0360dc490b7b6e69a5a011353b2738ab7251b62e Mon Sep 17 00:00:00 2001 From: Ilya Nikolaevskiy Date: Thu, 5 Mar 2020 15:33:34 +0100 Subject: [PATCH] Fix RtpReplayer so what vp9 fuzzer would work Replayer isn't triggered in any pre- or post-submit checks and is built only as a part of fuzzers. Therefore it got out of sync with the requirement of Call::Config::trials being set. Bug: chromium:1030755 Change-Id: I467a5fa19137020f6fc748b6adb6f82a8a88f9d1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169847 Reviewed-by: Artem Titov Commit-Queue: Ilya Nikolaevskiy Cr-Commit-Position: refs/heads/master@{#30695} --- test/fuzzers/utils/BUILD.gn | 1 + test/fuzzers/utils/rtp_replayer.cc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/test/fuzzers/utils/BUILD.gn b/test/fuzzers/utils/BUILD.gn index 165ac93d8c..af70cc7875 100644 --- a/test/fuzzers/utils/BUILD.gn +++ b/test/fuzzers/utils/BUILD.gn @@ -18,6 +18,7 @@ rtc_library("rtp_replayer") { "../../../api/rtc_event_log", "../../../api/task_queue:default_task_queue_factory", "../../../api/test/video:function_video_factory", + "../../../api/transport:field_trial_based_config", "../../../api/video_codecs:video_codecs_api", "../../../call", "../../../call:call_interfaces", diff --git a/test/fuzzers/utils/rtp_replayer.cc b/test/fuzzers/utils/rtp_replayer.cc index 4a4179991e..94a54586ac 100644 --- a/test/fuzzers/utils/rtp_replayer.cc +++ b/test/fuzzers/utils/rtp_replayer.cc @@ -16,6 +16,7 @@ #include #include "api/task_queue/default_task_queue_factory.h" +#include "api/transport/field_trial_based_config.h" #include "rtc_base/strings/json.h" #include "system_wrappers/include/clock.h" #include "test/call_config_utils.h" @@ -62,6 +63,8 @@ void RtpReplayer::Replay( CreateDefaultTaskQueueFactory(); Call::Config call_config(&event_log); call_config.task_queue_factory = task_queue_factory.get(); + FieldTrialBasedConfig field_trials; + call_config.trials = &field_trials; std::unique_ptr call(Call::Create(call_config)); SetupVideoStreams(&receive_stream_configs, stream_state.get(), call.get());