zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused method VideoCodingModule::DiscardedPackets().

Browse Source 
This method isn't called and the value it represents, is made available
via the stats APIs.

BUG=none

Review-Url: https://codereview.webrtc.org/2760613002
Cr-Commit-Position: refs/heads/master@{#17287}
This commit is contained in:
tommi
2017-03-17 05:48:24 -07:00
committed by Commit bot
parent b1db3702f7
commit 05e908b10b
6 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/video_coding/include/video_coding.h
View File

@ -394,12 +394,6 @@ class VideoCodingModule : public Module {
// < 0, on error. // < 0, on error.
virtual int32_t Delay() const = 0; virtual int32_t Delay() const = 0;
// Returns the number of packets discarded by the jitter buffer due to being
// too late. This can include duplicated packets which arrived after the
// frame was sent to the decoder. Therefore packets which were prematurely
// NACKed will be counted.
virtual uint32_t DiscardedPackets() const = 0;
// Robustness APIs // Robustness APIs
// Set the receiver robustness mode. The mode decides how the receiver // Set the receiver robustness mode. The mode decides how the receiver

4
webrtc/modules/video_coding/receiver.cc
View File

@ -239,10 +239,6 @@ void VCMReceiver::ReceiveStatistics(uint32_t* bitrate, uint32_t* framerate) {
jitter_buffer_.IncomingRateStatistics(framerate, bitrate); jitter_buffer_.IncomingRateStatistics(framerate, bitrate);
} }
uint32_t VCMReceiver::DiscardedPackets() const {
return jitter_buffer_.num_discarded_packets();
}
void VCMReceiver::SetNackMode(VCMNackMode nackMode, void VCMReceiver::SetNackMode(VCMNackMode nackMode,
int64_t low_rtt_nack_threshold_ms, int64_t low_rtt_nack_threshold_ms,
int64_t high_rtt_nack_threshold_ms) { int64_t high_rtt_nack_threshold_ms) {

1
webrtc/modules/video_coding/receiver.h
View File

@ -68,7 +68,6 @@ class VCMReceiver {
bool prefer_late_decoding); bool prefer_late_decoding);
void ReleaseFrame(VCMEncodedFrame* frame); void ReleaseFrame(VCMEncodedFrame* frame);
void ReceiveStatistics(uint32_t* bitrate, uint32_t* framerate); void ReceiveStatistics(uint32_t* bitrate, uint32_t* framerate);
uint32_t DiscardedPackets() const;
// NACK. // NACK.
void SetNackMode(VCMNackMode nackMode, void SetNackMode(VCMNackMode nackMode,

4
webrtc/modules/video_coding/video_coding_impl.cc
View File

@ -231,10 +231,6 @@ class VideoCodingModuleImpl : public VideoCodingModule {
int32_t Delay() const override { return receiver_.Delay(); } int32_t Delay() const override { return receiver_.Delay(); }
uint32_t DiscardedPackets() const override {
return receiver_.DiscardedPackets();
}
int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode, int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode,
VCMDecodeErrorMode errorMode) override { VCMDecodeErrorMode errorMode) override {
return receiver_.SetReceiverRobustnessMode(robustnessMode, errorMode); return receiver_.SetReceiverRobustnessMode(robustnessMode, errorMode);

1
webrtc/modules/video_coding/video_coding_impl.h
View File

@ -179,7 +179,6 @@ class VideoReceiver : public Module {
int32_t SetMinimumPlayoutDelay(uint32_t minPlayoutDelayMs); int32_t SetMinimumPlayoutDelay(uint32_t minPlayoutDelayMs);
int32_t SetRenderDelay(uint32_t timeMS); int32_t SetRenderDelay(uint32_t timeMS);
int32_t Delay() const; int32_t Delay() const;
uint32_t DiscardedPackets() const;
int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode, int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode,
VCMDecodeErrorMode errorMode); VCMDecodeErrorMode errorMode);

4
webrtc/modules/video_coding/video_receiver.cc
View File

@ -411,10 +411,6 @@ int32_t VideoReceiver::Delay() const {
return _timing->TargetVideoDelay(); return _timing->TargetVideoDelay();
} }
uint32_t VideoReceiver::DiscardedPackets() const {
return _receiver.DiscardedPackets();
}
int VideoReceiver::SetReceiverRobustnessMode( int VideoReceiver::SetReceiverRobustnessMode(
ReceiverRobustness robustnessMode, ReceiverRobustness robustnessMode,
VCMDecodeErrorMode decode_error_mode) { VCMDecodeErrorMode decode_error_mode) {