zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unify "control reaches end of non-void function" style

Browse Source 
BUG=webrtc:12008

Change-Id: I1cabe99738b3968af60a305bd9593bd47f7e9b6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/190480
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32506}
This commit is contained in:
Philipp Hancke
2020-10-27 11:30:19 +01:00
committed by Commit Bot
parent 18e6edd57a
commit 05f9ccdf23
3 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/media_types.cc
View File

@ -31,9 +31,7 @@ std::string MediaTypeToString(MediaType type) {
RTC_NOTREACHED(); RTC_NOTREACHED();
return ""; return "";
} }
FATAL(); RTC_CHECK(false);
// Not reachable; avoids compile warning.
return "";
} }
} // namespace cricket } // namespace cricket

6
pc/peer_connection_factory.cc
View File

@ -140,8 +140,7 @@ RtpCapabilities PeerConnectionFactory::GetRtpSenderCapabilities(
case cricket::MEDIA_TYPE_UNSUPPORTED: case cricket::MEDIA_TYPE_UNSUPPORTED:
return RtpCapabilities(); return RtpCapabilities();
} }
// Not reached; avoids compile warning. RTC_CHECK(false);
FATAL();
} }
RtpCapabilities PeerConnectionFactory::GetRtpReceiverCapabilities( RtpCapabilities PeerConnectionFactory::GetRtpReceiverCapabilities(
@ -167,8 +166,7 @@ RtpCapabilities PeerConnectionFactory::GetRtpReceiverCapabilities(
case cricket::MEDIA_TYPE_UNSUPPORTED: case cricket::MEDIA_TYPE_UNSUPPORTED:
return RtpCapabilities(); return RtpCapabilities();
} }
// Not reached; avoids compile warning. RTC_CHECK(false);
FATAL();
} }
rtc::scoped_refptr<AudioSourceInterface> rtc::scoped_refptr<AudioSourceInterface>

3
pc/rtp_parameters_conversion.cc
View File

@ -76,8 +76,7 @@ RTCErrorOr<cricket::FeedbackParam> ToCricketFeedbackParam(
} }
return cricket::FeedbackParam(cricket::kRtcpFbParamTransportCc); return cricket::FeedbackParam(cricket::kRtcpFbParamTransportCc);
} }
// Not reached; avoids compile warning. RTC_CHECK(false);
FATAL();
} }
template <typename C> template <typename C>