zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Make RTCP cumulative_lost be a signed value"

Browse Source 
This reverts commit 4c34f435db2b921b82b8be19ee5c1746f46cb188.

Reason for revert: Broke internal projects. Type mismatch.

Original change's description:
> Make RTCP cumulative_lost be a signed value
> 
> This is formally defined as a signed 24-bit value in RFC 3550 section 6.4.1.
> See RFC 3550 Appendix A.3 for the reason why it may turn negative.
> 
> Noticed on discuss-webrtc mailing list.
> 
> BUG=webrtc:8626
> 
> Change-Id: I7317f73e9490a876e8445bd3d6b66095ce53ca0a
> Reviewed-on: https://webrtc-review.googlesource.com/30901
> Reviewed-by: Stefan Holmer <stefan@webrtc.org>
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21142}

TBR=stefan@webrtc.org,hta@webrtc.org

Change-Id: I544f7979d584cfb72a2d0d526f4fef84aebeecb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8626
Reviewed-on: https://webrtc-review.googlesource.com/31040
Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
Commit-Queue: Zhi Huang <zhihuang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21144}
This commit is contained in:
Zhi Huang
2017-12-07 18:12:35 +00:00
committed by Commit Bot
parent 292a73eeea
commit 062a8ead3b
5 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/rtp_rtcp/source/rtcp_sender_unittest.cc
View File

@ -358,7 +358,7 @@ TEST_F(RtcpSenderTest, SendRrWithOneReportBlock) {
const rtcp::ReportBlock& rb = parser()->receiver_report()->report_blocks()[0];
EXPECT_EQ(kRemoteSsrc, rb.source_ssrc());
EXPECT_EQ(0U, rb.fraction_lost());
EXPECT_EQ(0, rb.cumulative_lost());
EXPECT_EQ(0U, rb.cumulative_lost());
EXPECT_EQ(kSeqNum, rb.extended_high_seq_num());
}