zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark AsyncInvoker as deprecated

Browse Source 
Also fix similar annotation on NackModule to have effect
(when defining an alias with C++ using, ABSL_DEPRECATED should appear
on the left hand side).

Bug: webrtc:12339
Change-Id: Id80a20bf2c56a826777b8a40e06ac5c65e4f8db7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217242
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33905}
This commit is contained in:
Niels Möller
2021-05-03 16:03:22 +02:00
committed by WebRTC LUCI CQ
parent de88b08b94
commit 0694ce7d1b
5 changed files with 39 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
rtc_base/thread_unittest.cc
View File

@ -521,7 +521,7 @@ TEST(ThreadTest, ThreeThreadsInvoke) {
// Asynchronously invoke SetAndInvokeSet on |thread1| and wait until
// |thread1| starts the call.
static void AsyncInvokeSetAndWait(AsyncInvoker* invoker,
static void AsyncInvokeSetAndWait(DEPRECATED_AsyncInvoker* invoker,
Thread* thread1,
Thread* thread2,
LockedBool* out) {
@ -536,7 +536,7 @@ TEST(ThreadTest, ThreeThreadsInvoke) {
}
};
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
LockedBool thread_a_called(false);
// Start the sequence A --(invoke)--> B --(async invoke)--> C --(invoke)--> A.
@ -761,7 +761,7 @@ class AsyncInvokeTest : public ::testing::Test {
};
TEST_F(AsyncInvokeTest, FireAndForget) {
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
// Create and start the thread.
auto thread = Thread::CreateWithSocketServer();
thread->Start();
@ -773,7 +773,7 @@ TEST_F(AsyncInvokeTest, FireAndForget) {
}
TEST_F(AsyncInvokeTest, NonCopyableFunctor) {
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
// Create and start the thread.
auto thread = Thread::CreateWithSocketServer();
thread->Start();
@ -804,7 +804,7 @@ TEST_F(AsyncInvokeTest, KillInvokerDuringExecute) {
EXPECT_FALSE(invoker_destroyed);
functor_finished.Set();
};
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
invoker.AsyncInvoke<void>(RTC_FROM_HERE, thread.get(), functor);
functor_started.Wait(Event::kForever);
@ -833,7 +833,7 @@ TEST_F(AsyncInvokeTest, KillInvokerDuringExecuteWithReentrantInvoke) {
Thread thread(std::make_unique<NullSocketServer>());
thread.Start();
{
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
auto reentrant_functor = [&reentrant_functor_run] {
reentrant_functor_run = true;
};
@ -852,7 +852,7 @@ TEST_F(AsyncInvokeTest, KillInvokerDuringExecuteWithReentrantInvoke) {
}
TEST_F(AsyncInvokeTest, Flush) {
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
AtomicBool flag1;
AtomicBool flag2;
// Queue two async calls to the current thread.
@ -868,7 +868,7 @@ TEST_F(AsyncInvokeTest, Flush) {
}
TEST_F(AsyncInvokeTest, FlushWithIds) {
AsyncInvoker invoker;
DEPRECATED_AsyncInvoker invoker;
AtomicBool flag1;
AtomicBool flag2;
// Queue two async calls to the current thread, one with a message id.