zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

packethistory: s/kMaxPaddingtHistory/kMaxPaddingHistory

Browse Source 
BUG=None

Change-Id: I554ff068c2350b9f14c12d935d7bfdd466dc5186
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227351
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#34642}
This commit is contained in:
Philipp Hancke
2021-08-04 11:33:51 +02:00
committed by WebRTC LUCI CQ
parent 287f377b86
commit 06bb4649dc
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/rtp_rtcp/source/rtp_packet_history.cc
View File

@ -24,7 +24,7 @@
namespace webrtc { namespace webrtc {
constexpr size_t RtpPacketHistory::kMaxCapacity; constexpr size_t RtpPacketHistory::kMaxCapacity;
constexpr size_t RtpPacketHistory::kMaxPaddingtHistory; constexpr size_t RtpPacketHistory::kMaxPaddingHistory;
constexpr int64_t RtpPacketHistory::kMinPacketDurationMs; constexpr int64_t RtpPacketHistory::kMinPacketDurationMs;
constexpr int RtpPacketHistory::kMinPacketDurationRtt; constexpr int RtpPacketHistory::kMinPacketDurationRtt;
constexpr int RtpPacketHistory::kPacketCullingDelayFactor; constexpr int RtpPacketHistory::kPacketCullingDelayFactor;
@ -160,7 +160,7 @@ void RtpPacketHistory::PutRtpPacket(std::unique_ptr<RtpPacketToSend> packet,
StoredPacket(std::move(packet), send_time_ms, packets_inserted_++); StoredPacket(std::move(packet), send_time_ms, packets_inserted_++);
if (enable_padding_prio_) { if (enable_padding_prio_) {
if (padding_priority_.size() >= kMaxPaddingtHistory - 1) { if (padding_priority_.size() >= kMaxPaddingHistory - 1) {
padding_priority_.erase(std::prev(padding_priority_.end())); padding_priority_.erase(std::prev(padding_priority_.end()));
} }
auto prio_it = padding_priority_.insert(&packet_history_[packet_index]); auto prio_it = padding_priority_.insert(&packet_history_[packet_index]);

2
modules/rtp_rtcp/source/rtp_packet_history.h
View File

@ -54,7 +54,7 @@ class RtpPacketHistory {
// Maximum number of packets we ever allow in the history. // Maximum number of packets we ever allow in the history.
static constexpr size_t kMaxCapacity = 9600; static constexpr size_t kMaxCapacity = 9600;
// Maximum number of entries in prioritized queue of padding packets. // Maximum number of entries in prioritized queue of padding packets.
static constexpr size_t kMaxPaddingtHistory = 63; static constexpr size_t kMaxPaddingHistory = 63;
// Don't remove packets within max(1000ms, 3x RTT). // Don't remove packets within max(1000ms, 3x RTT).
static constexpr int64_t kMinPacketDurationMs = 1000; static constexpr int64_t kMinPacketDurationMs = 1000;
static constexpr int kMinPacketDurationRtt = 3; static constexpr int kMinPacketDurationRtt = 3;

2
modules/rtp_rtcp/source/rtp_packet_history_unittest.cc
View File

@ -300,7 +300,7 @@ TEST_P(RtpPacketHistoryTest, RemovesLowestPrioPaddingWhenAtMaxCapacity) {
// Tests the absolute upper bound on number of packets in the prioritized // Tests the absolute upper bound on number of packets in the prioritized
// set of potential padding packets. // set of potential padding packets.
const size_t kMaxNumPackets = RtpPacketHistory::kMaxPaddingtHistory; const size_t kMaxNumPackets = RtpPacketHistory::kMaxPaddingHistory;
hist_.SetStorePacketsStatus(StorageMode::kStoreAndCull, kMaxNumPackets * 2); hist_.SetStorePacketsStatus(StorageMode::kStoreAndCull, kMaxNumPackets * 2);
hist_.SetRtt(1); hist_.SetRtt(1);