zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make video quality tests to always take a fixed duration

Browse Source 
It was possible before if an input fps dropped due to cpu adaptation

Also, this CL removes occasional test failure (it could've happened if
input framerate got very low)

Bug: webrtc:11432,webrtc:11426
Change-Id: Id1a4df23302f7b8ab6781f1e7cca5112bfcfe9ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170469
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30802}
This commit is contained in:
Ilya Nikolaevskiy
2020-03-16 13:01:25 +01:00
committed by Commit Bot
parent e3f257c4ee
commit 06c7095bc7
3 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
video/video_analyzer.h
View File

@ -41,6 +41,7 @@ class VideoAnalyzer : public PacketReceiver,
double avg_psnr_threshold,
double avg_ssim_threshold,
int duration_frames,
TimeDelta test_duration,
FILE* graph_data_output_file,
const std::string& graph_title,
uint32_t ssrc_to_analyze,
@ -147,7 +148,8 @@ class VideoAnalyzer : public PacketReceiver,
public:
CapturedFrameForwarder(VideoAnalyzer* analyzer,
Clock* clock,
int frames_to_process);
int frames_to_capture,
TimeDelta test_duration);
void SetSource(rtc::VideoSourceInterface<VideoFrame>* video_source);
private:
@ -167,7 +169,8 @@ class VideoAnalyzer : public PacketReceiver,
VideoSourceInterface<VideoFrame>* video_source_;
Clock* clock_;
int captured_frames_ RTC_GUARDED_BY(crit_);
const int frames_to_process_;
const int frames_to_capture_;
const Timestamp test_end_;
};
struct FrameWithPsnr {
@ -263,6 +266,7 @@ class VideoAnalyzer : public PacketReceiver,
rtc::CriticalSection crit_;
const int frames_to_process_;
const Timestamp test_end_;
int frames_recorded_ RTC_GUARDED_BY(comparison_lock_);
int frames_processed_ RTC_GUARDED_BY(comparison_lock_);
int captured_frames_ RTC_GUARDED_BY(comparison_lock_);