From 0804fba0fd721e60fbb36697eea375e132015a63 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Sun, 25 Jul 2021 11:52:55 +0200 Subject: [PATCH] Remove duplicated or non effective build flags. -Winconsistent-missing-override is part of -Wall so there is no need to explicitly set it. -Wthread-safety and -Wimplicit-fallthrough are set by default by Chromium's toolchain and there is no need to duplicated it in WebRTC GN files: gn desc out/Debug/ //rtc_base cflags | grep "Wthread-safety" -Wthread-safety -Wthread-safety gn desc out/Debug/ //rtc_base cflags | grep "implicit" -Wimplicit-fallthrough -Wimplicit-fallthrough Bug: None Change-Id: Ie5104f7c6d508c7b45788420bf111a17b8b10939 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226868 Commit-Queue: Mirko Bonadei Reviewed-by: Nico Weber Cr-Commit-Position: refs/heads/master@{#34549} --- BUILD.gn | 3 --- 1 file changed, 3 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index f2713f62d2..4afbdc7b92 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -344,9 +344,6 @@ config("common_config") { if (is_clang) { cflags += [ "-Wc++11-narrowing", - "-Wimplicit-fallthrough", - "-Wthread-safety", - "-Winconsistent-missing-override", "-Wundef", ]