zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Roll "Enable SSE, SSE2, and run-time detected SSE4.1 for libopus.""

Browse Source 
This reverts commit 466620b326c5743d9e3ce0d5af967fd977c5cf38.

Reason for revert: Break downstream clients which are still expecting the previous references for NetEqDecodingTest.TestOpusBitExactness.

Original change's description:
> Roll "Enable SSE, SSE2, and run-time detected SSE4.1 for libopus."
> 
> We manually roll third_party since we need to update impacted tests,
> namely bit-exact comparison of expected neteq_opus results.
> They have changed due to SSE optimization enabled here:
> 85d355e530
> 
> For consistency sake roll_deps has been invoked:
> 
> Roll chromium_revision db720b4ab9..ae94013397 (606025:606579)
> 
> Change log: db720b4ab9..ae94013397
> Full diff: db720b4ab9..ae94013397
> 
> Changed dependencies
> * src/base: fee916f36b..f428263956
> * src/build: 02b0a894b0..3f61809684
> * src/ios: 95aadfb43f..fb48cd850c
> * src/testing: 03b25bebb5..f6a2832441
> * src/third_party: 360db5b8aa..8209b47661
> * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/dd412c428a..384d0eaf19
> * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2e722b007d..f04a3a61ad
> * src/third_party/depot_tools: 4d2d5b4bbe..edcefdcf7d
> * src/third_party/freetype/src: f56830ed40..fb0d66d04c
> * src/tools: a8e76f0ca5..f8ace9b670
> DEPS diff: db720b4ab9..ae94013397/DEPS
> 
> Clang version changed 344066:346388
> Details: db720b4ab9..ae94013397/tools/clang/scripts/update.py
> 
> Bug: webrtc:9530
> Change-Id: I8a016c5834c4f05fc17e3a84a5e139eeaeaee510
> Reviewed-on: https://webrtc-review.googlesource.com/c/110040
> Commit-Queue: Yves Gerey <yvesg@webrtc.org>
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25588}

TBR=phoglund@webrtc.org,ivoc@webrtc.org,yvesg@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:9530
Change-Id: I01549abdcfbcad70881ff9aeee913df68d0f0052
Reviewed-on: https://webrtc-review.googlesource.com/c/110602
Reviewed-by: Yves Gerey <yvesg@google.com>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#25591}
This commit is contained in:
Yves Gerey
2018-11-12 09:02:59 +00:00
committed by Commit Bot
parent 0b1b5c1b2a
commit 09102a02cf
3 changed files with 30 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
modules/audio_coding/acm2/audio_coding_module_unittest.cc
View File

@ -1439,14 +1439,14 @@ TEST_F(AcmSenderBitExactnessOldApi, MAYBE_G722_stereo_20ms) {
TEST_F(AcmSenderBitExactnessOldApi, Opus_stereo_20ms) {
ASSERT_NO_FATAL_FAILURE(SetUpTest("opus", 48000, 2, 120, 960, 960));
Run(AcmReceiverBitExactnessOldApi::PlatformChecksum(
"fd5d57d6d766908e6a7211e2a5c7f78a",
"fd5d57d6d766908e6a7211e2a5c7f78a",
"3e285b74510e62062fbd8142dacd16e9",
"3e285b74510e62062fbd8142dacd16e9",
"439e97ad1932c49923b5da029c17dd5e",
"038ec90f5f3fc2320f3090f8ecef6bb7",
"038ec90f5f3fc2320f3090f8ecef6bb7"),
AcmReceiverBitExactnessOldApi::PlatformChecksum(
"b693bd95c2ee2354f92340dd09e9da68",
"b693bd95c2ee2354f92340dd09e9da68",
"78cf8f03157358acdc69f6835caa0d9b",
"78cf8f03157358acdc69f6835caa0d9b",
"ab88b1a049c36bdfeb7e8b057ef6982a",
"27fef7b799393347ec3b5694369a1c36",
"27fef7b799393347ec3b5694369a1c36"),
@ -1459,14 +1459,14 @@ TEST_F(AcmSenderBitExactnessNewApi, MAYBE_OpusFromFormat_stereo_20ms) {
ASSERT_NO_FATAL_FAILURE(SetUpTestExternalEncoder(
AudioEncoderOpus::MakeAudioEncoder(*config, 120), 120));
Run(AcmReceiverBitExactnessOldApi::PlatformChecksum(
"fd5d57d6d766908e6a7211e2a5c7f78a",
"fd5d57d6d766908e6a7211e2a5c7f78a",
"3e285b74510e62062fbd8142dacd16e9",
"3e285b74510e62062fbd8142dacd16e9",
"439e97ad1932c49923b5da029c17dd5e",
"038ec90f5f3fc2320f3090f8ecef6bb7",
"038ec90f5f3fc2320f3090f8ecef6bb7"),
AcmReceiverBitExactnessOldApi::PlatformChecksum(
"b693bd95c2ee2354f92340dd09e9da68",
"b693bd95c2ee2354f92340dd09e9da68",
"78cf8f03157358acdc69f6835caa0d9b",
"78cf8f03157358acdc69f6835caa0d9b",
"ab88b1a049c36bdfeb7e8b057ef6982a",
"27fef7b799393347ec3b5694369a1c36",
"27fef7b799393347ec3b5694369a1c36"),
@ -1481,14 +1481,14 @@ TEST_F(AcmSenderBitExactnessNewApi, OpusFromFormat_stereo_20ms_voip) {
ASSERT_NO_FATAL_FAILURE(SetUpTestExternalEncoder(
AudioEncoderOpus::MakeAudioEncoder(*config, 120), 120));
Run(AcmReceiverBitExactnessOldApi::PlatformChecksum(
"3cd4e1bc2acd9440bb9e97af34080ffc",
"3cd4e1bc2acd9440bb9e97af34080ffc",
"b0325df4e8104f04e03af23c0b75800e",
"b0325df4e8104f04e03af23c0b75800e",
"1c81121f5d9286a5a865d01dbab22ce8",
"11d547f89142e9ef03f37d7ca7f32379",
"11d547f89142e9ef03f37d7ca7f32379"),
AcmReceiverBitExactnessOldApi::PlatformChecksum(
"4fc0af0aa06c26454af09832d3ec1b4e",
"4fc0af0aa06c26454af09832d3ec1b4e",
"4eab2259b6fe24c22dd242a113e0b3d9",
"4eab2259b6fe24c22dd242a113e0b3d9",
"839ea60399447268ee0f0262a50b75fd",
"1815fd5589cad0c6f6cf946c76b81aeb",
"1815fd5589cad0c6f6cf946c76b81aeb"),

12
modules/audio_coding/neteq/neteq_unittest.cc
View File

@ -502,11 +502,11 @@ TEST_F(NetEqDecodingTest, MAYBE_TestOpusBitExactness) {
webrtc::test::ResourcePath("audio_coding/neteq_opus", "rtp");
const std::string output_checksum =
PlatformChecksum("2c05677daa968d6c68b92adf4affb7cd9bb4d363",
PlatformChecksum("14a63b3c7b925c82296be4bafc71bec85f2915c2",
"b7b7ed802b0e18ee416973bf3b9ae98599b0181d",
"5876e52dda90d5ca433c3726555b907b97c86374",
"2c05677daa968d6c68b92adf4affb7cd9bb4d363",
"2c05677daa968d6c68b92adf4affb7cd9bb4d363");
"14a63b3c7b925c82296be4bafc71bec85f2915c2",
"14a63b3c7b925c82296be4bafc71bec85f2915c2");
const std::string network_stats_checksum =
PlatformChecksum("adb3272498e436d1c019cbfd71610e9510c54497",
@ -537,11 +537,11 @@ TEST_F(NetEqDecodingTest, MAYBE_TestOpusDtxBitExactness) {
webrtc::test::ResourcePath("audio_coding/neteq_opus_dtx", "rtp");
const std::string output_checksum =
PlatformChecksum("2ac10c4e79aeedd0df2863b079da5848b40f00b5",
PlatformChecksum("713af6c92881f5aab1285765ee6680da9d1c06ce",
"3ec991b96872123f1554c03c543ca5d518431e46",
"da9f9a2d94e0c2d67342fad4965d7b91cda50b25",
"2ac10c4e79aeedd0df2863b079da5848b40f00b5",
"2ac10c4e79aeedd0df2863b079da5848b40f00b5");
"713af6c92881f5aab1285765ee6680da9d1c06ce",
"713af6c92881f5aab1285765ee6680da9d1c06ce");
const std::string network_stats_checksum =
"bab58dc587d956f326056d7340c96eb9d2d3cc21";