zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of deprecated version of NackSender::SendNack [2/2]

Browse Source 
[1/2] - Make new version pure-virtual, and deprecated version non-pure.
        This will allow deleting the deprecated version from downstream
        projects.
[2/2] - Remove deprecated version.

TBR=sprang@webrtc.org,stefan@webrtc.org

Bug: webrtc:10336
Change-Id: I3904da12ec471980adfb22f2e61304d42de4ec66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144043
Reviewed-by: Elad Alon <eladalon@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28419}
This commit is contained in:
Elad Alon
2019-06-27 17:51:12 +02:00
committed by Commit Bot
parent 7e00c679a5
commit 099b02a366
2 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/BUILD.gn
View File

@ -54,7 +54,6 @@ rtc_source_set("module_api") {
"../api:rtp_headers", "../api:rtp_headers",
"../api/video:video_frame_type", "../api/video:video_frame_type",
"../modules/rtp_rtcp:rtp_video_header", "../modules/rtp_rtcp:rtp_video_header",
"../rtc_base:deprecation", # TODO(bugs.webrtc.org/10336): Remove.
"../rtc_base:safe_conversions", "../rtc_base:safe_conversions",
"../rtc_base/system:rtc_export", "../rtc_base/system:rtc_export",
] ]

6
modules/include/module_common_types.h
View File

@ -20,7 +20,6 @@
#include "modules/include/module_common_types_public.h" #include "modules/include/module_common_types_public.h"
#include "modules/include/module_fec_types.h" #include "modules/include/module_fec_types.h"
#include "modules/rtp_rtcp/source/rtp_video_header.h" #include "modules/rtp_rtcp/source/rtp_video_header.h"
#include "rtc_base/deprecation.h" // TODO(bugs.webrtc.org/10336): Remove.
#include "rtc_base/system/rtc_export.h" #include "rtc_base/system/rtc_export.h"
namespace webrtc { namespace webrtc {
@ -67,11 +66,6 @@ class CallStatsObserver {
// Interface used by NackModule and JitterBuffer. // Interface used by NackModule and JitterBuffer.
class NackSender { class NackSender {
public: public:
// // TODO(bugs.webrtc.org/10336): Update downstream and remove this method.
// Make the one remaining version of SendNack() pure virtual again.
RTC_DEPRECATED virtual void SendNack(
const std::vector<uint16_t>& sequence_numbers) {}
// If |buffering_allowed|, other feedback messages (e.g. key frame requests) // If |buffering_allowed|, other feedback messages (e.g. key frame requests)
// may be added to the same outgoing feedback message. In that case, it's up // may be added to the same outgoing feedback message. In that case, it's up
// to the user of the interface to ensure that when all buffer-able messages // to the user of the interface to ensure that when all buffer-able messages