zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing respondsToSelector call for new optional delegate method.

Browse Source 
Without checking respondsToSelector, clients that don't implement the
optional delegate method will crash.

Bug: webrtc:13446
Change-Id: I3b06b15e818ca80e6afae9491c30f38c6b262eb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242600
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Auto-Submit: Chuck Hays <haysc@webrtc.org>
Commit-Queue: Chuck Hays <haysc@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35573}
This commit is contained in:
Chuck Hays
2021-12-21 14:24:46 -06:00
committed by WebRTC LUCI CQ
parent 01ae9dcf0e
commit 0a3836a882
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sdk/objc/api/peerconnection/RTCPeerConnection.mm
View File

@ -239,7 +239,10 @@ void PeerConnectionDelegateAdapter::OnIceCandidateError(const std::string &addre
url:url
errorCode:error_code
errorText:error_text];
[peer_connection.delegate peerConnection:peer_connection didFailToGatherIceCandidate:event];
if ([peer_connection.delegate respondsToSelector:@selector(peerConnection:
didFailToGatherIceCandidate:)]) {
[peer_connection.delegate peerConnection:peer_connection didFailToGatherIceCandidate:event];
}
}
void PeerConnectionDelegateAdapter::OnIceCandidatesRemoved(