zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revamp the ProcessThreadImpl implementation.

Browse Source 
* Add a new WakeUp method that gives a module a chance to be called back right away on the worker thread.
* Wrote unit tests for the class.
* Significantly reduce the amount of locking.
  - ProcessThreadImpl itself does a lot less locking.
  - Reimplemented the way we keep track of when to make calls to Process.
    This reduces the amount of calls to TimeUntilNextProcess and since most implementations of that function grab a lock, this means less locking.
* Renamed ProcessThread::CreateProcessThread to ProcessThread::Create.
* Added thread checks for Start/Stop.  Threading model of other functions is now documented.
* We now log an error if an implementation of TimeUntilNextProcess returns a negative value (some implementations do, but the method should only return a positive nr of ms).
* Removed the DestroyProcessThread method and instead force callers to use scoped_ptr<> to maintain object lifetime.

BUG=2822
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35999004

Cr-Commit-Position: refs/heads/master@{#8261}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8261 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org
2015-02-06 09:44:12 +00:00
parent 75025434bf
commit 0c3e12b7bf
15 changed files with 463 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
webrtc/modules/utility/source/process_thread_impl.h
View File

@ -13,37 +13,52 @@
#include <list>
#include "webrtc/base/criticalsection.h"
#include "webrtc/base/thread_checker.h"
#include "webrtc/modules/utility/interface/process_thread.h"
#include "webrtc/system_wrappers/interface/critical_section_wrapper.h"
#include "webrtc/system_wrappers/interface/event_wrapper.h"
#include "webrtc/system_wrappers/interface/thread_wrapper.h"
#include "webrtc/typedefs.h"
namespace webrtc {
class ProcessThreadImpl : public ProcessThread
{
public:
ProcessThreadImpl();
virtual ~ProcessThreadImpl();
virtual int32_t Start();
virtual int32_t Stop();
class ProcessThreadImpl : public ProcessThread {
public:
ProcessThreadImpl();
~ProcessThreadImpl() override;
virtual int32_t RegisterModule(Module* module);
virtual int32_t DeRegisterModule(const Module* module);
int32_t Start() override;
int32_t Stop() override;
protected:
static bool Run(void* obj);
void WakeUp(Module* module) override;
bool Process();
int32_t RegisterModule(Module* module);
int32_t DeRegisterModule(const Module* module);
private:
typedef std::list<Module*> ModuleList;
EventWrapper& _timeEvent;
CriticalSectionWrapper* _critSectModules;
ModuleList _modules;
ThreadWrapper* _thread;
protected:
static bool Run(void* obj);
bool Process();
private:
rtc::ThreadChecker thread_checker_;
const rtc::scoped_ptr<EventWrapper> wake_up_;
rtc::scoped_ptr<ThreadWrapper> thread_;
struct ModuleCallback {
ModuleCallback(Module* module) : module(module), next_callback(0) {}
bool operator==(const ModuleCallback& cb) const {
return cb.module == module;
}
Module* const module;
int64_t next_callback; // Absolute timestamp.
};
rtc::CriticalSection lock_; // Used to guard modules_ and stop_.
typedef std::list<ModuleCallback> ModuleList;
ModuleList modules_;
bool stop_;
};
} // namespace webrtc
#endif // WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_