zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dcsctp: Merge ReconfigResponseSN/ReconfigRequestSN

Browse Source 
Adding strong types went a little too far as these two types represent
the same sequence number. A "request sequence number" is a number, that
- when responded to - will be used as "response sequence number".

Having them separate added confusion and just a lot of type-casting.

Bug: webrtc:12614
Change-Id: I4636ea8f2252023a2d5a9b7033763e1978b1812e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214130
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33789}
This commit is contained in:
Victor Boivie
2021-04-06 20:51:03 +02:00
committed by Commit Bot
parent 0b0afaa81a
commit 0e73602a9f
9 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/dcsctp/packet/parameter/reconfiguration_response_parameter.cc
View File

@ -71,7 +71,7 @@ ReconfigurationResponseParameter::Parse(rtc::ArrayView<const uint8_t> data) {
return absl::nullopt;
}
ReconfigResponseSN response_sequence_number(reader->Load32<4>());
ReconfigRequestSN response_sequence_number(reader->Load32<4>());
Result result;
uint32_t result_nbr = reader->Load32<8>();
switch (result_nbr) {