zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dcsctp: Merge ReconfigResponseSN/ReconfigRequestSN

Browse Source 
Adding strong types went a little too far as these two types represent
the same sequence number. A "request sequence number" is a number, that
- when responded to - will be used as "response sequence number".

Having them separate added confusion and just a lot of type-casting.

Bug: webrtc:12614
Change-Id: I4636ea8f2252023a2d5a9b7033763e1978b1812e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214130
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33789}
This commit is contained in:
Victor Boivie
2021-04-06 20:51:03 +02:00
committed by Commit Bot
parent 0b0afaa81a
commit 0e73602a9f
9 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/dcsctp/packet/parameter/reconfiguration_response_parameter_test.cc
View File

@ -24,7 +24,7 @@ namespace {
TEST(ReconfigurationResponseParameterTest, SerializeAndDeserializeFirstForm) {
ReconfigurationResponseParameter parameter(
ReconfigResponseSN(1),
ReconfigRequestSN(1),
ReconfigurationResponseParameter::Result::kSuccessPerformed);
std::vector<uint8_t> serialized;
@ -44,7 +44,7 @@ TEST(ReconfigurationResponseParameterTest, SerializeAndDeserializeFirstForm) {
TEST(ReconfigurationResponseParameterTest,
SerializeAndDeserializeFirstFormSecondForm) {
ReconfigurationResponseParameter parameter(
ReconfigResponseSN(1),
ReconfigRequestSN(1),
ReconfigurationResponseParameter::Result::kSuccessPerformed, TSN(2),
TSN(3));