From 10393922099416d552f193e00fa7abada8b2cc26 Mon Sep 17 00:00:00 2001 From: Minyue Li Date: Wed, 18 Aug 2021 23:37:43 +0200 Subject: [PATCH] Add a unittest to NetEq StatisticsCalculator for discarded packets counter. Bug: webrtc:8199 Change-Id: I32127af1ae6692717f28dbf2d820cd67c0b6a66a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229300 Reviewed-by: Jakob Ivarsson Commit-Queue: Minyue Li Cr-Commit-Position: refs/heads/master@{#34808} --- .../neteq/statistics_calculator_unittest.cc | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/modules/audio_coding/neteq/statistics_calculator_unittest.cc b/modules/audio_coding/neteq/statistics_calculator_unittest.cc index e6a9c26c4b..a15cac4ebf 100644 --- a/modules/audio_coding/neteq/statistics_calculator_unittest.cc +++ b/modules/audio_coding/neteq/statistics_calculator_unittest.cc @@ -179,4 +179,37 @@ TEST(StatisticsCalculator, InterruptionCounterDoNotLogBeforeDecoding) { EXPECT_EQ(1, lts.interruption_count); } +// Test that |discarded_primary_packets| as reported from +// |GetOperationsAndState| always matches the arguments to |PacketsDiscarded| +// accumulated. +TEST(StatisticsCalculator, DiscardedPackets) { + StatisticsCalculator statistics_calculator; + EXPECT_EQ( + 0u, + statistics_calculator.GetOperationsAndState().discarded_primary_packets); + + statistics_calculator.PacketsDiscarded(1); + EXPECT_EQ( + 1u, + statistics_calculator.GetOperationsAndState().discarded_primary_packets); + + statistics_calculator.PacketsDiscarded(10); + EXPECT_EQ( + 11u, + statistics_calculator.GetOperationsAndState().discarded_primary_packets); + + // Calling |SecondaryPacketsDiscarded| does not modify + // |discarded_primary_packets|. + statistics_calculator.SecondaryPacketsDiscarded(1); + EXPECT_EQ( + 11u, + statistics_calculator.GetOperationsAndState().discarded_primary_packets); + + // Calling |FlushedPacketBuffer| does not modify |discarded_primary_packets|. + statistics_calculator.FlushedPacketBuffer(); + EXPECT_EQ( + 11u, + statistics_calculator.GetOperationsAndState().discarded_primary_packets); +} + } // namespace webrtc