zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Makes the max padding factor default 3.0x

Browse Source 
Bug: webrtc:11508
Change-Id: Ib2e8f5216140f55a590f43fc52a50058703cc2bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173750
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31120}
This commit is contained in:
Erik Språng
2020-04-22 12:19:26 +02:00
committed by Commit Bot
parent 9ce77fda75
commit 1120f7d895
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/rtp_rtcp/source/rtp_sender.cc
View File

@ -92,8 +92,10 @@ bool HasBweExtension(const RtpHeaderExtensionMap& extensions_map) {
} }
double GetMaxPaddingSizeFactor(const WebRtcKeyValueConfig* field_trials) { double GetMaxPaddingSizeFactor(const WebRtcKeyValueConfig* field_trials) {
// Effectively no limit by default. // Too low factor means RTX payload padding is rarely used and ineffective.
constexpr double kDefaultFactor = IP_PACKET_SIZE; // Too high means we risk interrupting regular media packets.
// In practice, 3x seems to yield reasonable results.
constexpr double kDefaultFactor = 3.0;
if (!field_trials) { if (!field_trials) {
return kDefaultFactor; return kDefaultFactor;
} }