zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Re-enabling SanitizerTest.MsanUninitialized.

Browse Source 
Using EXPECT_DEATH instead of __msan_set_expect_umr.

Bug: webrtc:9116
Change-Id: I40222e920cd213d3d1366629023d4d1c4fbc35f9
Reviewed-on: https://webrtc-review.googlesource.com/79661
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23532}
This commit is contained in:
Mirko Bonadei
2018-06-05 21:44:50 +02:00
committed by Commit Bot
parent b544f6c2f5
commit 1127fb9856
1 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
rtc_base/sanitizer_unittest.cc
View File

@ -122,28 +122,20 @@ struct Bar {
Foo foo;
};
// Run the callback, and crash if it *doesn't* make an uninitialized memory
// read. If MSan isn't on, just run the callback.
// Run the callback, and expect a crash if it *doesn't* make an uninitialized
// memory read. If MSan isn't on, just run the callback.
template <typename F>
void MsanExpectUninitializedRead(F&& f) {
#if RTC_HAS_MSAN
// Allow uninitialized memory reads.
RTC_LOG(LS_INFO) << "__msan_set_expect_umr(1)";
__msan_set_expect_umr(1);
#endif
EXPECT_DEATH(f(), "");
#else
f();
#if RTC_HAS_MSAN
// Disallow uninitialized memory reads again, and verify that at least
// one uninitialized memory read happened while we weren't looking.
RTC_LOG(LS_INFO) << "__msan_set_expect_umr(0)";
__msan_set_expect_umr(0);
#endif
}
} // namespace
// TODO(b/9116): Enable the test when the bug is fixed.
TEST(SanitizerTest, DISABLED_MsanUninitialized) {
TEST(SanitizerTest, MsanUninitialized) {
Bar bar = MsanUninitialized<Bar>({});
// Check that a read after initialization is OK.
bar.ID = 1;