zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ )

Browse Source 
Reason for revert:
Fixing the Gn error and try to reland.

Original issue's description:
> Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ )
>
> Reason for revert:
> Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio
>
> Original issue's description:
> > Creating webrtc/modules:module_api
> >
> > This target keeps track of .h the files under webrtc/modules/include/
> > that are not part of any target.
> > If a .h file is not part of a target the 'gn check' utility is not
> > able to spot if a target is missing a dependency because even if
> > it parses '#include' directives it is not able to find a target that
> > contains these headers.
> >
> > BUG=webrtc:7513
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2838873002
> > Cr-Commit-Position: refs/heads/master@{#17880}
> > Committed: 5a1a092ed0
>
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7513
>
> Review-Url: https://codereview.webrtc.org/2839963005
> Cr-Commit-Position: refs/heads/master@{#17881}
> Committed: bb08c3e296

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=kjellander@webrtc.org
BUG=webrtc:7513

Review-Url: https://codereview.webrtc.org/2843913002
Cr-Commit-Position: refs/heads/master@{#17884}
This commit is contained in:
mbonadei
2017-04-26 03:38:35 -07:00
committed by Commit bot
parent f53f47f4dc
commit 1140f97e48
22 changed files with 73 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/modules/audio_coding/BUILD.gn
View File

@ -127,6 +127,7 @@ rtc_source_set("audio_coding_module_typedefs") {
"include/audio_coding_module_typedefs.h",
]
deps = [
"..:module_api",
"../..:webrtc_common",
]
}
@ -163,6 +164,7 @@ rtc_static_library("audio_coding") {
}
deps = audio_coding_deps + [
"..:module_api",
"../../api/audio_codecs:audio_codecs_api",
"../../api/audio_codecs:builtin_audio_decoder_factory",
":audio_coding_module_typedefs",
@ -1067,6 +1069,7 @@ rtc_static_library("neteq") {
":isac_fix",
":neteq_decoder_enum",
":pcm16b",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:audio_codecs_api",
"../../base:gtest_prod",
@ -1198,6 +1201,7 @@ if (rtc_include_tests) {
":audio_coding_module_typedefs",
":audio_format_conversion",
":pcm16b_c",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:builtin_audio_decoder_factory",
"../../base:rtc_base_approved",
@ -1301,6 +1305,7 @@ if (rtc_include_tests) {
":audio_coding",
":audio_coding_module_typedefs",
":audio_format_conversion",
"..:module_api",
"../../:webrtc_common",
"../../base:rtc_base_approved",
"../../system_wrappers",
@ -1328,6 +1333,7 @@ if (rtc_include_tests) {
deps = [
":audio_coding",
":audio_format_conversion",
"..:module_api",
"../../:webrtc_common",
"../../base:rtc_base_approved",
"../../system_wrappers",
@ -1429,7 +1435,9 @@ if (rtc_include_tests) {
rtc_test("neteq_rtpplay") {
testonly = true
defines = []
deps = []
deps = [
"..:module_api",
]
sources = [
"neteq/tools/neteq_rtpplay.cc",
]
@ -1509,6 +1517,7 @@ if (rtc_include_tests) {
":neteq",
":neteq_unittest_tools",
":pcm16b",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:audio_codecs_api",
"../../api/audio_codecs:builtin_audio_decoder_factory",
@ -1534,6 +1543,7 @@ if (rtc_include_tests) {
deps = [
":neteq",
":neteq_unittest_tools",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:builtin_audio_decoder_factory",
"../../base:rtc_base_approved",
@ -1588,6 +1598,7 @@ if (rtc_include_tests) {
deps = [
":audio_encoder_interface",
":pcm16b",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:audio_codecs_api",
"../../base:rtc_base_approved",
@ -1625,6 +1636,7 @@ if (rtc_include_tests) {
":ilbc",
":isac",
":pcm16b",
"..:module_api",
"../..:webrtc_common",
"//testing/gtest",
]
@ -2136,6 +2148,7 @@ if (rtc_include_tests) {
":red",
":rent_a_codec",
":webrtc_opus",
"..:module_api",
"../..:webrtc_common",
"../../api/audio_codecs:audio_codecs_api",
"../../api/audio_codecs:builtin_audio_decoder_factory",