zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ )

Browse Source 
Reason for revert:
Fixing the Gn error and try to reland.

Original issue's description:
> Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ )
>
> Reason for revert:
> Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio
>
> Original issue's description:
> > Creating webrtc/modules:module_api
> >
> > This target keeps track of .h the files under webrtc/modules/include/
> > that are not part of any target.
> > If a .h file is not part of a target the 'gn check' utility is not
> > able to spot if a target is missing a dependency because even if
> > it parses '#include' directives it is not able to find a target that
> > contains these headers.
> >
> > BUG=webrtc:7513
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2838873002
> > Cr-Commit-Position: refs/heads/master@{#17880}
> > Committed: 5a1a092ed0
>
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7513
>
> Review-Url: https://codereview.webrtc.org/2839963005
> Cr-Commit-Position: refs/heads/master@{#17881}
> Committed: bb08c3e296

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
TBR=kjellander@webrtc.org
BUG=webrtc:7513

Review-Url: https://codereview.webrtc.org/2843913002
Cr-Commit-Position: refs/heads/master@{#17884}
This commit is contained in:
mbonadei
2017-04-26 03:38:35 -07:00
committed by Commit bot
parent f53f47f4dc
commit 1140f97e48
22 changed files with 73 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/audio_processing/BUILD.gn
View File

@ -230,6 +230,7 @@ rtc_static_library("audio_processing") {
defines = []
deps = [
"..:module_api",
"../..:webrtc_common",
"../../audio/utility:audio_frame_operations",
"../../base:gtest_prod",
@ -531,6 +532,7 @@ if (rtc_include_tests) {
deps = [
":audio_processing",
":audioproc_test_utils",
"..:module_api",
"../..:webrtc_common",
"../../base:gtest_prod",
"../../base:protobuf_utils",
@ -749,6 +751,7 @@ if (rtc_include_tests) {
deps = [
":audio_processing",
"..:module_api",
"../../base:rtc_base_approved",
"../../common_audio",
"../../system_wrappers:system_wrappers",
@ -764,6 +767,7 @@ if (rtc_include_tests) {
]
deps = [
":audio_processing",
"..:module_api",
"../..:webrtc_common",
"../../common_audio:common_audio",
"../../system_wrappers:metrics_default",