zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Demote RTC_NOTREACHED in pseudotcp RTT processing to warning.

Browse Source 
This problem shouldn't be severe enough to require a crash, and it can be triggered by untrusted network data.
We'll print a warning instead.

Bug: chromium:877790
Change-Id: Ie1f33d85dc7f0ccbbc1d027b73f77b964c6f7e46
Reviewed-on: https://webrtc-review.googlesource.com/96880
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24579}
This commit is contained in:
Jonas Olsson
2018-08-30 15:35:15 +02:00
committed by Commit Bot
parent 5b6afc0ce6
commit 11a922086b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
p2p/base/pseudotcp.cc
View File

@ -729,7 +729,7 @@ bool PseudoTcp::process(Segment& seg) {
<< " rto: " << m_rx_rto; << " rto: " << m_rx_rto;
#endif // _DEBUGMSG #endif // _DEBUGMSG
} else { } else {
RTC_NOTREACHED(); RTC_LOG(LS_WARNING) << "rtt < 0";
} }
} }