From 12912255424a293397270c7b50fb56e82ecad4ea Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Wed, 18 Jul 2018 22:06:42 +0200 Subject: [PATCH] Expose audio codec factories in libwebrtc. This explicitly exposes the following functions, without relying on (wrong) transitive dependency. * CreateBuiltinAudioDecoderFactory() * CreateBuiltinAudioEncoderFactory() Manual check: % gn gen out/test && ninja -C out/test webrtc % nm -C out/test/obj/libwebrtc.a | grep CreateBuiltinAudio 0000000000000000 T webrtc::CreateBuiltinAudioDecoderFactory() 0000000000000000 T webrtc::CreateBuiltinAudioEncoderFactory() Bug: webrtc:9528 Change-Id: I0d2b0a8294dc90b553a7dff9045ea6e4f0d0d416 Reviewed-on: https://webrtc-review.googlesource.com/89062 Reviewed-by: Mirko Bonadei Commit-Queue: Yves Gerey Cr-Commit-Position: refs/heads/master@{#24042} --- BUILD.gn | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 4420843c6f..f29fbdd7fb 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -350,6 +350,17 @@ if (!build_with_chromium) { "video", ] + # Additional factory functions to be exposed. + # Rational: These factories are small enough (89 KiB / 32+ MiB) + # to be unconditionaly included for user convenience. + # That begin said: + # TODO(yvesg) Consider making all non-core APIs optional, so that users + # can build a customized library tailored to their needs. + deps += [ + "api/audio_codecs:builtin_audio_decoder_factory", + "api/audio_codecs:builtin_audio_encoder_factory", + ] + if (build_with_mozilla) { deps += [ "api/video:video_frame",