Separate build target for rtc_base/numerics/safe_minmax.h

So that we can avoid dependency cycles.

Bug: none
Change-Id: I821d9f1319dff01403d6e4e310cbb2d4b2b125e8
Reviewed-on: https://webrtc-review.googlesource.com/60500
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22328}

api/audio_codecs/g711/BUILD.gn

@@ -24,6 +24,7 @@ rtc_static_library("audio_encoder_g711") {
     "../../..:webrtc_common",
     "../../../modules/audio_coding:g711",
     "../../../rtc_base:rtc_base_approved",
+    "../../../rtc_base:safe_minmax",
   ]
 }
 

api/audio_codecs/g722/BUILD.gn

@@ -32,6 +32,7 @@ rtc_static_library("audio_encoder_g722") {
     "../../..:webrtc_common",
     "../../../modules/audio_coding:g722",
     "../../../rtc_base:rtc_base_approved",
+    "../../../rtc_base:safe_minmax",
   ]
 }
 

api/audio_codecs/ilbc/BUILD.gn

@@ -32,6 +32,7 @@ rtc_static_library("audio_encoder_ilbc") {
     "../../..:webrtc_common",
     "../../../modules/audio_coding:ilbc",
     "../../../rtc_base:rtc_base_approved",
+    "../../../rtc_base:safe_minmax",
   ]
 }
 

audio/BUILD.gn

@@ -80,6 +80,7 @@ rtc_static_library("audio") {
     "../rtc_base:rtc_base",
     "../rtc_base:rtc_base_approved",
     "../rtc_base:rtc_task_queue",
+    "../rtc_base:safe_minmax",
     "../rtc_base:stringutils",
     "../system_wrappers",
     "../system_wrappers:field_trial_api",

common_video/BUILD.gn

@@ -65,6 +65,7 @@ rtc_static_library("common_video") {
     "../rtc_base:checks",
     "../rtc_base:rtc_base",
     "../rtc_base:rtc_task_queue",
+    "../rtc_base:safe_minmax",
     "../system_wrappers",
     "//third_party/libyuv",
   ]

logging/BUILD.gn

@@ -220,6 +220,7 @@ rtc_static_library("rtc_event_log_impl_base") {
     "../rtc_base:checks",
     "../rtc_base:rtc_base_approved",
     "../rtc_base:rtc_task_queue_api",
+    "../rtc_base:safe_minmax",
     "../rtc_base:sequenced_task_checker",
   ]
 

modules/audio_coding/BUILD.gn

@@ -856,6 +856,7 @@ rtc_static_library("webrtc_opus") {
     "../../rtc_base:checks",
     "../../rtc_base:rtc_base_approved",
     "../../rtc_base:rtc_numerics",
+    "../../rtc_base:safe_minmax",
     "../../system_wrappers:field_trial_api",
   ]
   public_deps = [
@@ -1088,6 +1089,7 @@ rtc_static_library("neteq") {
     "../../rtc_base:checks",
     "../../rtc_base:gtest_prod",
     "../../rtc_base:rtc_base_approved",
+    "../../rtc_base:safe_minmax",
     "../../rtc_base:sanitizer",
     "../../rtc_base/system:fallthrough",
     "../../system_wrappers:field_trial_api",

modules/audio_processing/BUILD.gn

@@ -156,6 +156,7 @@ rtc_static_library("audio_processing") {
     "../../rtc_base:deprecation",
     "../../rtc_base:gtest_prod",
     "../../rtc_base:protobuf_utils",
+    "../../rtc_base:safe_minmax",
     "../../rtc_base:sanitizer",
     "../../system_wrappers:cpu_features_api",
     "../../system_wrappers:field_trial_api",
@@ -558,6 +559,7 @@ if (rtc_include_tests) {
       "../../rtc_base:protobuf_utils",
       "../../rtc_base:rtc_base",
       "../../rtc_base:rtc_base_approved",
+      "../../rtc_base:safe_minmax",
       "../../system_wrappers",
       "../../system_wrappers:cpu_features_api",
       "../../test:test_support",

modules/audio_processing/aec3/BUILD.gn

@@ -108,6 +108,7 @@ rtc_static_library("aec3") {
     "../../../common_audio:common_audio_c",
     "../../../rtc_base:checks",
     "../../../rtc_base:rtc_base_approved",
+    "../../../rtc_base:safe_minmax",
     "../../../system_wrappers:cpu_features_api",
     "../../../system_wrappers:metrics_api",
   ]
@@ -138,6 +139,7 @@ if (rtc_include_tests) {
       "../../../api/audio:aec3_config",
       "../../../rtc_base:checks",
       "../../../rtc_base:rtc_base_approved",
+      "../../../rtc_base:safe_minmax",
       "../../../system_wrappers:cpu_features_api",
       "../../../test:test_support",
     ]

modules/audio_processing/agc2/BUILD.gn

@@ -31,6 +31,7 @@ rtc_source_set("agc2") {
     "../../../rtc_base:checks",
     "../../../rtc_base:gtest_prod",
     "../../../rtc_base:rtc_base_approved",
+    "../../../rtc_base:safe_minmax",
   ]
 }
 

modules/congestion_controller/BUILD.gn

@@ -110,6 +110,7 @@ rtc_source_set("estimators") {
     "../../rtc_base:checks",
     "../../rtc_base:rtc_base_approved",
     "../../rtc_base:rtc_numerics",
+    "../../rtc_base:safe_minmax",
     "../../system_wrappers:field_trial_api",
     "../../system_wrappers:metrics_api",
     "../remote_bitrate_estimator:remote_bitrate_estimator",

modules/congestion_controller/goog_cc/BUILD.gn

@@ -91,6 +91,7 @@ rtc_source_set("estimators") {
     "../../../rtc_base:checks",
     "../../../rtc_base:rtc_base_approved",
     "../../../rtc_base:rtc_numerics",
+    "../../../rtc_base:safe_minmax",
     "../../../system_wrappers:field_trial_api",
     "../../../system_wrappers:metrics_api",
     "../../remote_bitrate_estimator",

modules/congestion_controller/rtp/BUILD.gn

@@ -42,6 +42,7 @@ rtc_static_library("congestion_controller") {
     "../../../rtc_base:checks",
     "../../../rtc_base:rate_limiter",
     "../../../rtc_base:rtc_task_queue_api",
+    "../../../rtc_base:safe_minmax",
     "../../../rtc_base:sequenced_task_checker",
     "../../../system_wrappers",
     "../../../system_wrappers:field_trial_api",

modules/remote_bitrate_estimator/BUILD.gn

@@ -51,6 +51,7 @@ rtc_static_library("remote_bitrate_estimator") {
     "../../modules/rtp_rtcp:rtp_rtcp_format",
     "../../rtc_base:checks",
     "../../rtc_base:rtc_base_approved",
+    "../../rtc_base:safe_minmax",
     "../../system_wrappers",
     "../../system_wrappers:field_trial_api",
     "../../system_wrappers:metrics_api",
@@ -141,6 +142,7 @@ if (rtc_include_tests) {
       "../../rtc_base:rtc_base",
       "../../rtc_base:rtc_base_approved",
       "../../rtc_base:rtc_numerics",
+      "../../rtc_base:safe_minmax",
       "../../rtc_base/experiments:alr_experiment",
       "../../rtc_base/system:fallthrough",
       "../../system_wrappers",

modules/rtp_rtcp/BUILD.gn

@@ -206,6 +206,7 @@ rtc_static_library("rtp_rtcp") {
     "../../rtc_base:rate_limiter",
     "../../rtc_base:rtc_base_approved",
     "../../rtc_base:rtc_numerics",
+    "../../rtc_base:safe_minmax",
     "../../rtc_base:sequenced_task_checker",
     "../../rtc_base:stringutils",
     "../../rtc_base/system:fallthrough",

p2p/BUILD.gn

@@ -89,6 +89,7 @@ rtc_static_library("rtc_p2p") {
     "../logging:ice_log",
     "../rtc_base:checks",
     "../rtc_base:rtc_base",
+    "../rtc_base:safe_minmax",
     "../rtc_base:stringutils",
     "../system_wrappers:field_trial_api",
   ]

rtc_base/BUILD.gn

@@ -129,6 +129,17 @@ rtc_source_set("safe_compare") {
   ]
 }
 
+rtc_source_set("safe_minmax") {
+  sources = [
+    "numerics/safe_minmax.h",
+  ]
+  deps = [
+    ":checks",
+    ":safe_compare",
+    ":type_traits",
+  ]
+}
+
 rtc_source_set("stringutils") {
   sources = [
     "strings/string_builder.h",
@@ -210,7 +221,6 @@ rtc_source_set("rtc_base_approved_generic") {
     "numerics/moving_max_counter.h",
     "numerics/safe_conversions.h",
     "numerics/safe_conversions_impl.h",
-    "numerics/safe_minmax.h",
     "onetimeevent.h",
     "pathutils.cc",
     "pathutils.h",
@@ -1002,6 +1012,7 @@ if (rtc_include_tests) {
       ":rtc_base_tests_utils",
       ":rtc_task_queue",
       ":safe_compare",
+      ":safe_minmax",
       ":stringutils",
       "../api:array_view",
       "../system_wrappers:system_wrappers",

rtc_tools/BUILD.gn

@@ -292,6 +292,7 @@ if (rtc_include_tests) {
       "../modules/audio_processing",
       "../modules/audio_processing/vad",
       "../rtc_base:rtc_base_approved",
+      "../rtc_base:safe_minmax",
       "../system_wrappers:metrics_default",
       "../test:test_support",
       "//build/win:default_exe_manifest",

test/fuzzers/BUILD.gn

@@ -448,6 +448,7 @@ webrtc_fuzzer_test("audio_processing_fuzzer") {
     "../../modules/audio_processing",
     "../../modules/audio_processing/aec3",
     "../../rtc_base:rtc_base_approved",
+    "../../rtc_base:safe_minmax",
   ]
   seed_corpus = "corpora/audio_processing-corpus"
 }