zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete logic to set picture id and tl0 pic idx in encoders.

Browse Source 
It would be nice to also delete the fields from CodecSpecificInfo,
but those fields are used on the receive side.

Bug: webrtc:8830
Change-Id: I1a3f13ea2c024cbd73b33fd9dd58e531d3576a55
Reviewed-on: https://webrtc-review.googlesource.com/64780
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22625}
This commit is contained in:
Niels Möller
2018-03-27 14:16:55 +02:00
committed by Commit Bot
parent d45e078e89
commit 150dcb0a9a
19 changed files with 47 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/video_coding/include/video_codec_interface.h
View File

@ -28,19 +28,19 @@ class RTPFragmentationHeader; // forward declaration
// Note: if any pointers are added to this struct, it must be fitted
// with a copy-constructor. See below.
struct CodecSpecificInfoVP8 {
// TODO(nisse): Delete, set by PayloadRouter.
// TODO(nisse): Used on receive side only. Move elsewhere?
int16_t pictureId; // Negative value to skip pictureId.
bool nonReference;
uint8_t simulcastIdx;
uint8_t temporalIdx;
bool layerSync;
// TODO(nisse): Delete, set by PayloadRouter.
// TODO(nisse): Used on receive side only. Move elsewhere?
int tl0PicIdx; // Negative value to skip tl0PicIdx.
int8_t keyIdx; // Negative value to skip keyIdx.
};
struct CodecSpecificInfoVP9 {
// TODO(nisse): Delete, set by PayloadRouter.
// TODO(nisse): Used on receive side only. Move elsewhere?
int16_t picture_id; // Negative value to skip pictureId.
bool first_frame_in_picture; // First frame, increment picture_id.
@ -49,7 +49,7 @@ struct CodecSpecificInfoVP9 {
bool flexible_mode;
bool ss_data_available;
// TODO(nisse): Delete, set by PayloadRouter.
// TODO(nisse): Used on receive side only. Move elsewhere?
int tl0_pic_idx; // Negative value to skip tl0PicIdx.
uint8_t temporal_idx;
uint8_t spatial_idx;