zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing flaky LocalP2PTestSctpDataChannel test.

Browse Source 
SCTP data channels are closed asynchronously in-band, unlike RTP
data channels, so the test must be slightly modified.

TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1527833003

Cr-Commit-Position: refs/heads/master@{#11017}
This commit is contained in:
deadbeef
2015-12-14 19:32:34 -08:00
committed by Commit bot
parent c9be00797e
commit 158879305b
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
talk/app/webrtc/peerconnection_unittest.cc
View File

@ -1615,10 +1615,9 @@ TEST_F(P2PTestConductor, LocalP2PTestSctpDataChannel) {
kMaxWaitMs); kMaxWaitMs);
receiving_client()->data_channel()->Close(); receiving_client()->data_channel()->Close();
// Send new offer and answer. EXPECT_TRUE_WAIT(!initializing_client()->data_observer()->IsOpen(),
receiving_client()->Negotiate(); kMaxWaitMs);
EXPECT_FALSE(initializing_client()->data_observer()->IsOpen()); EXPECT_TRUE_WAIT(!receiving_client()->data_observer()->IsOpen(), kMaxWaitMs);
EXPECT_FALSE(receiving_client()->data_observer()->IsOpen());
} }
// This test sets up a call between two parties and creates a data channel. // This test sets up a call between two parties and creates a data channel.