zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove handling unused rtcp packets.

Browse Source 
App, ExtendedJitterReport and VoipMetric in ExtenedReports are not
used when received (no callbacks, no state change), so removed.

BUG=webrtc:5260

Review-Url: https://codereview.webrtc.org/2320703003
Cr-Commit-Position: refs/heads/master@{#14204}
This commit is contained in:
danilchap
2016-09-13 23:54:48 -07:00
committed by Commit bot
parent cdf37a9293
commit 17366bc090
4 changed files with 2 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
webrtc/modules/rtp_rtcp/source/rtcp_receiver_help.cc
View File

@ -23,12 +23,7 @@ RTCPPacketInformation::RTCPPacketInformation()
: rtcpPacketTypeFlags(0),
remoteSSRC(0),
nackSequenceNumbers(),
applicationSubType(0),
applicationName(0),
applicationData(),
applicationLength(0),
rtt(0),
interArrivalJitter(0),
sliPictureId(0),
rpsiPictureId(0),
receiverEstimatedMaxBitrate(0),
@ -36,40 +31,9 @@ RTCPPacketInformation::RTCPPacketInformation()
ntp_frac(0),
rtp_timestamp(0),
xr_originator_ssrc(0),
xr_dlrr_item(false),
VoIPMetric(nullptr) {}
xr_dlrr_item(false) {}
RTCPPacketInformation::~RTCPPacketInformation() {
delete[] applicationData;
}
void RTCPPacketInformation::AddVoIPMetric(const RTCPVoIPMetric* metric) {
VoIPMetric.reset(new RTCPVoIPMetric());
memcpy(VoIPMetric.get(), metric, sizeof(RTCPVoIPMetric));
}
void RTCPPacketInformation::AddApplicationData(const uint8_t* data,
const uint16_t size) {
uint8_t* oldData = applicationData;
uint16_t oldLength = applicationLength;
// Don't copy more than kRtcpAppCode_DATA_SIZE bytes.
uint16_t copySize = size;
if (size > kRtcpAppCode_DATA_SIZE) {
copySize = kRtcpAppCode_DATA_SIZE;
}
applicationLength += copySize;
applicationData = new uint8_t[applicationLength];
if (oldData) {
memcpy(applicationData, oldData, oldLength);
memcpy(applicationData + oldLength, data, copySize);
delete[] oldData;
} else {
memcpy(applicationData, data, copySize);
}
}
RTCPPacketInformation::~RTCPPacketInformation() {}
void RTCPPacketInformation::ResetNACKPacketIdArray() {
nackSequenceNumbers.clear();