zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

APM: remove LevelEstimator

Browse Source 
Only used in unit tests and a duplication of what `capture_output_rms_`
already does.

This CL also removes `AudioProcessingStats::output_rms_dbfs`, which is
now unused.

Bug: webrtc:5298
Fix: chromium:1261339
Change-Id: I6e583c11d4abb58444c440509a8495a7f5ebc589
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235664
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35246}
This commit is contained in:
Alessio Bazzica
2021-10-19 13:32:02 +02:00
committed by WebRTC LUCI CQ
parent 00c62eddf4
commit 183c64ce19
16 changed files with 3 additions and 299 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/audio_processing/include/audio_processing.cc
View File

@ -210,9 +210,7 @@ std::string AudioProcessing::Config::ToString() const {
<< ", max_output_noise_level_dbfs: "
<< gain_controller2.adaptive_digital.max_output_noise_level_dbfs
<< "}}, residual_echo_detector: { enabled: "
<< residual_echo_detector.enabled
<< " }, level_estimation: { enabled: " << level_estimation.enabled
<< " }}";
<< residual_echo_detector.enabled << " }}";
return builder.str();
}

5
modules/audio_processing/include/audio_processing.h
View File

@ -386,11 +386,6 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface {
bool enabled = true;
} residual_echo_detector;
// Enables reporting of `output_rms_dbfs` in webrtc::AudioProcessingStats.
struct LevelEstimation {
bool enabled = false;
} level_estimation;
std::string ToString() const;
};

8
modules/audio_processing/include/audio_processing_statistics.h
View File

@ -24,14 +24,6 @@ struct RTC_EXPORT AudioProcessingStats {
AudioProcessingStats(const AudioProcessingStats& other);
~AudioProcessingStats();
// The root mean square (RMS) level in dBFS (decibels from digital
// full-scale) of the last capture frame, after processing. It is
// constrained to [-127, 0].
// The computation follows: https://tools.ietf.org/html/rfc6465
// with the intent that it can provide the RTP audio level indication.
// Only reported if level estimation is enabled in AudioProcessing::Config.
absl::optional<int> output_rms_dbfs;
// True if voice is detected in the last capture frame, after processing.
// It is conservative in flagging audio as speech, with low likelihood of
// incorrectly flagging a frame as voice.