zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN"

Browse Source 
This is a reland of e779847fb6499ac2dc4757de8c625ac377e9d0d4

Original change's description:
> Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN
>
> Also add explicit includes of rtc_base/string_utils.h in files depending on it.
>
> Bug: webrtc:6424
> Change-Id: Id6b53937ab2d185d092a5d8863018fd5f1a88e27
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135744
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27903}

Tbr: kwiberg@webrtc.org
Bug: webrtc:6424
Change-Id: Ic08d5d7fbc25ff89e4182d7c9cb3b0e8e356339a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135946
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27957}
This commit is contained in:
Niels Möller
2019-05-10 12:29:13 +02:00
committed by Commit Bot
parent baf9c62bc7
commit 198cf00532
9 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rtc_base/strings/string_builder.h
View File

@ -18,6 +18,8 @@
#include "absl/strings/string_view.h"
#include "api/array_view.h"
#include "rtc_base/string_encode.h"
// TODO(nisse): Delete, as as soon as downstream applications are updated to not
// rely in this indirect include.
#include "rtc_base/string_utils.h"
namespace rtc {
@ -64,7 +66,7 @@ class SimpleStringBuilder {
// An alternate way from operator<<() to append a string. This variant is
// slightly more efficient when the length of the string to append, is known.
SimpleStringBuilder& Append(const char* str, size_t length = SIZE_UNKNOWN);
SimpleStringBuilder& Append(const char* str, size_t length);
private:
bool IsConsistent() const {