zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AGC2: Remove unused parameters

Browse Source 
- `NoiseEstimator` and `LevelEstimator` enums
- `vad_probability_attack`
- `level_estimator_adjacent_speech_frames_threshold`
- `use_saturation_protector`
- `gain_applier_adjacent_speech_frames_threshold`
- `initial_saturation_margin_db`
- `extra_saturation_margin_db`

Bug: webrtc:7494
Change-Id: I12e40c8efe2d2126d7597ec18a78cf9d5d39baf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232903
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35096}
This commit is contained in:
Alessio Bazzica
2021-09-24 14:59:30 +02:00
committed by WebRTC LUCI CQ
parent f75f9c2b29
commit 1ac4f2a29e
10 changed files with 7 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
modules/audio_processing/gain_controller2_unittest.cc
View File

@ -129,64 +129,6 @@ TEST(GainController2, CheckFixedDigitalConfig) {
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2, CheckAdaptiveDigitalVadProbabilityAttackConfig) {
AudioProcessing::Config::GainController2 config;
// Reject invalid attack.
config.adaptive_digital.vad_probability_attack = -123.f;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.vad_probability_attack = 0.f;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.vad_probability_attack = 42.f;
EXPECT_FALSE(GainController2::Validate(config));
// Accept valid attack.
config.adaptive_digital.vad_probability_attack = 0.1f;
EXPECT_TRUE(GainController2::Validate(config));
config.adaptive_digital.vad_probability_attack = 1.f;
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2,
CheckAdaptiveDigitalLevelEstimatorSpeechFramesThresholdConfig) {
AudioProcessing::Config::GainController2 config;
config.adaptive_digital.level_estimator_adjacent_speech_frames_threshold = 0;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.level_estimator_adjacent_speech_frames_threshold = 1;
EXPECT_TRUE(GainController2::Validate(config));
config.adaptive_digital.level_estimator_adjacent_speech_frames_threshold = 7;
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2, CheckAdaptiveDigitalInitialSaturationMarginConfig) {
AudioProcessing::Config::GainController2 config;
config.adaptive_digital.initial_saturation_margin_db = -1.f;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.initial_saturation_margin_db = 0.f;
EXPECT_TRUE(GainController2::Validate(config));
config.adaptive_digital.initial_saturation_margin_db = 50.f;
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2, CheckAdaptiveDigitalExtraSaturationMarginConfig) {
AudioProcessing::Config::GainController2 config;
config.adaptive_digital.extra_saturation_margin_db = -1.f;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.extra_saturation_margin_db = 0.f;
EXPECT_TRUE(GainController2::Validate(config));
config.adaptive_digital.extra_saturation_margin_db = 50.f;
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2,
CheckAdaptiveDigitalGainApplierSpeechFramesThresholdConfig) {
AudioProcessing::Config::GainController2 config;
config.adaptive_digital.gain_applier_adjacent_speech_frames_threshold = 0;
EXPECT_FALSE(GainController2::Validate(config));
config.adaptive_digital.gain_applier_adjacent_speech_frames_threshold = 1;
EXPECT_TRUE(GainController2::Validate(config));
config.adaptive_digital.gain_applier_adjacent_speech_frames_threshold = 7;
EXPECT_TRUE(GainController2::Validate(config));
}
TEST(GainController2, CheckAdaptiveDigitalMaxGainChangeSpeedConfig) {
AudioProcessing::Config::GainController2 config;
config.adaptive_digital.max_gain_change_db_per_second = -1.f;