zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always pass arguments to INSTANTIATE_TEST_SUITE_P.

Browse Source 
Passing an empty arg is working at the moment but it is not
guaranteed to continue to work in the future.

This CL has been generated with:
git grep -l "INSTANTIATE_TEST_SUITE_P(," | xargs sed -i \
    "s/INSTANTIATE_TEST_SUITE_P(,/INSTANTIATE_TEST_SUITE_P(All,/g"

Bug: None
Change-Id: Icd2fb9d9d29aed5d692a234124bd990d0f097db4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153890
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29282}
This commit is contained in:
Mirko Bonadei
2019-09-23 08:34:50 +02:00
committed by Commit Bot
parent 63df20a1be
commit 1b575417b3
8 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pc/rtc_stats_collector_unittest.cc
View File

@ -2633,7 +2633,7 @@ TEST_P(RTCStatsCollectorTestWithParamKind,
EXPECT_TRUE(report->Get(*remote_inbound_rtp.transport_id));
}
INSTANTIATE_TEST_SUITE_P(,
INSTANTIATE_TEST_SUITE_P(All,
RTCStatsCollectorTestWithParamKind,
::testing::Values(cricket::MEDIA_TYPE_AUDIO, // "/0"
cricket::MEDIA_TYPE_VIDEO)); // "/1"

4
pc/used_ids_unittest.cc
View File

@ -79,7 +79,7 @@ constexpr TestParams kOneByteTestParams = {
constexpr TestParams kTwoByteTestParams = {
UsedRtpHeaderExtensionIds::IdDomain::kTwoByteAllowed, 255};
INSTANTIATE_TEST_SUITE_P(,
INSTANTIATE_TEST_SUITE_P(All,
UsedRtpHeaderExtensionIdsTest,
::testing::Values(kOneByteTestParams,
kTwoByteTestParams));
@ -152,7 +152,7 @@ TEST(UsedIdsDeathTest, DieWhenAllIdsAreOccupied) {
}
using UsedRtpHeaderExtensionIdsDeathTest = UsedRtpHeaderExtensionIdsTest;
INSTANTIATE_TEST_SUITE_P(,
INSTANTIATE_TEST_SUITE_P(All,
UsedRtpHeaderExtensionIdsDeathTest,
::testing::Values(kOneByteTestParams,
kTwoByteTestParams));