zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove SequencedTaskChecker from Y4mFileReader

Browse Source 
SequencedTaskChecker is not part of rtc_base_approved and will not work
in Chromium. This CL simply removes it since it was just a precaution
and is not necessary for the tool. The thread assumptions are stated in
the class comment.

TBR=phensman@webrtc.org

Bug: webrtc:9642
Change-Id: I871ac361975595d8ed07b2e2447e3581c9ba9968
Reviewed-on: https://webrtc-review.googlesource.com/95648
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24401}
This commit is contained in:
Magnus Jedvert
2018-08-23 12:39:22 +02:00
committed by Commit Bot
parent 4ff63cc9a1
commit 1b5e5db842
3 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
rtc_tools/BUILD.gn
View File

@ -69,7 +69,6 @@ rtc_static_library("y4m_file_reader") {
"../api/video:video_frame",
"../api/video:video_frame_i420",
"../rtc_base:rtc_base_approved",
"../rtc_base:sequenced_task_checker",
"//third_party/abseil-cpp/absl/types:optional",
]
}

2
rtc_tools/y4m_file_reader.cc
View File

@ -20,7 +20,6 @@
#include "api/video/i420_buffer.h"
#include "rtc_base/logging.h"
#include "rtc_base/refcountedobject.h"
#include "rtc_base/sequenced_task_checker.h"
#include "rtc_base/string_to_number.h"
#include "rtc_base/stringencode.h"
#include "rtc_base/stringutils.h"
@ -184,7 +183,6 @@ size_t Y4mFile::number_of_frames() const {
rtc::scoped_refptr<I420BufferInterface> Y4mFile::GetFrame(
size_t frame_index) const {
RTC_DCHECK_CALLED_SEQUENTIALLY(&thread_checker_);
RTC_CHECK_LT(frame_index, frame_positions_.size());
fsetpos(file_, &frame_positions_[frame_index]);

2
rtc_tools/y4m_file_reader.h
View File

@ -17,7 +17,6 @@
#include "api/video/video_frame.h"
#include "rtc_base/refcount.h"
#include "rtc_base/sequenced_task_checker.h"
namespace webrtc {
namespace test {
@ -89,7 +88,6 @@ class Y4mFile : public Video {
const int height_;
const float fps_;
const std::vector<fpos_t> frame_positions_;
const rtc::SequencedTaskChecker thread_checker_;
FILE* const file_;
};