zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable more VideoProcessorIntegrationTest tests on Linux 32-bit

Browse Source 
The previously disabled tests on TSan and UBSan are also failing on
Linux 32-bit.

BUG=webrtc:6781
R=ehmaldonado@webrtc.org
TBR=deadbeef@webrtc.org

Review URL: https://codereview.webrtc.org/2535913002 .

Cr-Commit-Position: refs/heads/master@{#15276}
This commit is contained in:
Henrik Kjellander
2016-11-28 19:34:32 +01:00
parent bb58435da0
commit 1bc3146e08
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
View File

@ -626,8 +626,9 @@ TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossH264) {
// One key frame (first frame only) in sequence. Setting |key_frame_interval| // One key frame (first frame only) in sequence. Setting |key_frame_interval|
// to -1 below means no periodic key frames in test. // to -1 below means no periodic key frames in test.
#if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) #if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) || \
// Fails on TSan and UBSan: https://bugs.webrtc.org/6781. (defined(WEBRTC_ARCH_32_BITS) && defined(WEBRTC_LINUX))
// Fails on TSan, UBSan and Linux 32-bit: https://bugs.webrtc.org/6781.
#define MAYBE_Process0PercentPacketLossVP9 DISABLED_Process0PercentPacketLossVP9 #define MAYBE_Process0PercentPacketLossVP9 DISABLED_Process0PercentPacketLossVP9
#else #else
#define MAYBE_Process0PercentPacketLossVP9 Process0PercentPacketLossVP9 #define MAYBE_Process0PercentPacketLossVP9 Process0PercentPacketLossVP9
@ -678,8 +679,9 @@ TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLossVP9) {
// low to high to medium. Check that quality and encoder response to the new // low to high to medium. Check that quality and encoder response to the new
// target rate/per-frame bandwidth (for each rate update) is within limits. // target rate/per-frame bandwidth (for each rate update) is within limits.
// One key frame (first frame only) in sequence. // One key frame (first frame only) in sequence.
#if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) #if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) || \
// Fails on TSan and UBSan: https://bugs.webrtc.org/6781. (defined(WEBRTC_ARCH_32_BITS) && defined(WEBRTC_LINUX))
// Fails on TSan, UBSan and Linux 32-bit: https://bugs.webrtc.org/6781.
#define MAYBE_ProcessNoLossChangeBitRateVP9 \ #define MAYBE_ProcessNoLossChangeBitRateVP9 \
DISABLED_ProcessNoLossChangeBitRateVP9 DISABLED_ProcessNoLossChangeBitRateVP9
#else #else
@ -718,9 +720,10 @@ TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossChangeBitRateVP9) {
// metrics averaged over whole sequence run. // metrics averaged over whole sequence run.
#if defined(WEBRTC_ANDROID) || defined(THREAD_SANITIZER) || \ #if defined(WEBRTC_ANDROID) || defined(THREAD_SANITIZER) || \
defined(UNDEFINED_SANITIZER) defined(UNDEFINED_SANITIZER) || \
(defined(WEBRTC_ARCH_32_BITS) && defined(WEBRTC_LINUX))
// Flaky on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=6057. // Flaky on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=6057.
// Fails on TSan and UBSan: https://bugs.webrtc.org/6781. // Fails on TSan, UBSan and Linux 32-bit: https://bugs.webrtc.org/6781.
#define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP9 \ #define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP9 \
DISABLED_ProcessNoLossChangeFrameRateFrameDropVP9 DISABLED_ProcessNoLossChangeFrameRateFrameDropVP9
#else #else
@ -754,8 +757,9 @@ TEST_F(VideoProcessorIntegrationTest,
} }
// VP9: Run with no packet loss and denoiser on. One key frame (first frame). // VP9: Run with no packet loss and denoiser on. One key frame (first frame).
#if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) #if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) || \
// Fails on TSan and UBSan: https://bugs.webrtc.org/6781. (defined(WEBRTC_ARCH_32_BITS) && defined(WEBRTC_LINUX))
// Fails on TSan, UBSan and Linux 32-bit: https://bugs.webrtc.org/6781.
#define MAYBE_ProcessNoLossDenoiserOnVP9 DISABLED_ProcessNoLossDenoiserOnVP9 #define MAYBE_ProcessNoLossDenoiserOnVP9 DISABLED_ProcessNoLossDenoiserOnVP9
#else #else
#define MAYBE_ProcessNoLossDenoiserOnVP9 ProcessNoLossDenoiserOnVP9 #define MAYBE_ProcessNoLossDenoiserOnVP9 ProcessNoLossDenoiserOnVP9
@ -783,8 +787,9 @@ TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossDenoiserOnVP9) {
// Run with no packet loss, at low bitrate. // Run with no packet loss, at low bitrate.
// spatial_resize is on, for this low bitrate expect one resize in sequence. // spatial_resize is on, for this low bitrate expect one resize in sequence.
// Resize happens on delta frame. Expect only one key frame (first frame). // Resize happens on delta frame. Expect only one key frame (first frame).
#if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) #if defined(THREAD_SANITIZER) || defined(UNDEFINED_SANITIZER) || \
// Fails on TSan and UBSan: https://bugs.webrtc.org/6781. (defined(WEBRTC_ARCH_32_BITS) && defined(WEBRTC_LINUX))
// Fails on TSan, UBSan and Linux 32-bit: https://bugs.webrtc.org/6781.
#define MAYBE_ProcessNoLossSpatialResizeFrameDropVP9 \ #define MAYBE_ProcessNoLossSpatialResizeFrameDropVP9 \
DISABLED_ProcessNoLossSpatialResizeFrameDropVP9 DISABLED_ProcessNoLossSpatialResizeFrameDropVP9
#else #else