From 1d36003181fed7a23537ebdeaca74ef9f50bed8f Mon Sep 17 00:00:00 2001 From: Henrik Kjellander Date: Fri, 27 Mar 2015 13:46:34 +0100 Subject: [PATCH] Suppress TSan errors triggered when deadlock detection is enabled. These are problematic when running with the default TSan settings which has deadlock detection enabled. Our bots still run with it disabled but we want to be able to turn it back on, thus this is needed. BUG=3911,4456 TESTED= Successfully executed: GYP_DEFINES="tsan=1 release_extra_cflags=-g use_allocator=none" webrtc/build/gyp_webrtc ninja -C out/Release rtc_unittests out/Release/rtc_unittests R=pbos@webrtc.org Review URL: https://webrtc-codereview.appspot.com/44899004 Cr-Commit-Position: refs/heads/master@{#8879} --- webrtc/build/sanitizers/tsan_suppressions_webrtc.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/webrtc/build/sanitizers/tsan_suppressions_webrtc.cc b/webrtc/build/sanitizers/tsan_suppressions_webrtc.cc index 4015803492..b177ba0d87 100644 --- a/webrtc/build/sanitizers/tsan_suppressions_webrtc.cc +++ b/webrtc/build/sanitizers/tsan_suppressions_webrtc.cc @@ -44,6 +44,7 @@ char kTSanDefaultSuppressions[] = // rtc_unittest // https://code.google.com/p/webrtc/issues/detail?id=3911 for details. +"race:rtc::AsyncInvoker::OnMessage\n" "race:rtc::FireAndForgetAsyncClosure::Execute\n" "race:rtc::MessageQueueManager::Clear\n" "race:rtc::Thread::Clear\n" @@ -51,6 +52,8 @@ char kTSanDefaultSuppressions[] = "race:webrtc/base/logging.cc\n" "race:webrtc/base/sharedexclusivelock_unittest.cc\n" "race:webrtc/base/signalthread_unittest.cc\n" +// https://code.google.com/p/webrtc/issues/detail?id=4456 +"deadlock:rtc::MessageQueueManager::ClearInternal\n" // libjingle_p2p_unittest // https://code.google.com/p/webrtc/issues/detail?id=2079