zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename a few MediaConfig::Video flags for consistency.

Browse Source 
enable_cpu_overuse_detection --> enable_cpu_adaptation
  disable_prerenderer_smoothing --> enable_prerenderer_smoothing

where the latter also gets opposite meaning.

Bug: none
Change-Id: Ic10de0871a87e86a899aefa72ecb7e46fcdeaa65
Reviewed-on: https://webrtc-review.googlesource.com/40280
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21726}
This commit is contained in:
Niels Möller
2018-01-18 15:25:12 +01:00
committed by Commit Bot
parent 700ef33edc
commit 1d7ecd29c7
9 changed files with 26 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
api/peerconnectioninterface.h
View File

@ -305,13 +305,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
bool dscp() const { return media_config.enable_dscp; }
void set_dscp(bool enable) { media_config.enable_dscp = enable; }
// TODO(nisse): The corresponding flag in MediaConfig and
// elsewhere should be renamed enable_cpu_adaptation.
bool cpu_adaptation() const {
return media_config.video.enable_cpu_overuse_detection;
return media_config.video.enable_cpu_adaptation;
}
void set_cpu_adaptation(bool enable) {
media_config.video.enable_cpu_overuse_detection = enable;
media_config.video.enable_cpu_adaptation = enable;
}
bool suspend_below_min_bitrate() const {
@ -321,14 +319,11 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
media_config.video.suspend_below_min_bitrate = enable;
}
// TODO(nisse): The negation in the corresponding MediaConfig
// attribute is inconsistent, and it should be renamed at some
// point.
bool prerenderer_smoothing() const {
return !media_config.video.disable_prerenderer_smoothing;
return media_config.video.enable_prerenderer_smoothing;
}
void set_prerenderer_smoothing(bool enable) {
media_config.video.disable_prerenderer_smoothing = !enable;
media_config.video.enable_prerenderer_smoothing = enable;
}
bool experiment_cpu_load_estimator() const {