Cleanup PacketBuffer tests to use immediate result

Browse Source

delete traces of the OnAssembledFrame callback
relax some expectation to better match test purpose,
in particular avoid verifying every test buffer is not cleared on new packet.
switch comparisons from EXPECT_EQ(constant, value) to more natural EXPECT_EQ(value, constant)

Bug: None
Change-Id: I81e2c9d0133221435cb2bb02c9190d9f32abd548
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158140
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29610}

...

This commit is contained in:

Danil Chapovalov

2019-10-24 12:44:23 +02:00

committed by Commit Bot

parent 4f2783b9fe

commit 1dac707ecb

1 changed files with 291 additions and 382 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

673

modules/video_coding/packet_buffer_unittest.cc

File diff suppressed because it is too large Load Diff