zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove some TODOs from pc/.

Browse Source 
Bug: webrtc:10198
Change-Id: I1782a8ef1248578fcc3ffc8c03b5419225a51350
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173625
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31113}
This commit is contained in:
Mirko Bonadei
2020-04-17 14:15:47 +02:00
committed by Commit Bot
parent e50c979811
commit 1f0677d01e
2 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pc/channel.cc
View File

@ -101,13 +101,8 @@ void RtpParametersFromMediaDescription(
bool is_stream_active, bool is_stream_active,
RtpParameters<Codec>* params) { RtpParameters<Codec>* params) {
params->is_stream_active = is_stream_active; params->is_stream_active = is_stream_active;
// TODO(pthatcher): Remove this once we're sure no one will give us
// a description without codecs. Currently the ORTC implementation is relying
// on this.
if (desc->has_codecs()) {
params->codecs = desc->codecs(); params->codecs = desc->codecs();
} // TODO(bugs.webrtc.org/11513): See if we really need
// TODO(pthatcher): See if we really need
// rtp_header_extensions_set() and remove it if we don't. // rtp_header_extensions_set() and remove it if we don't.
if (desc->rtp_header_extensions_set()) { if (desc->rtp_header_extensions_set()) {
params->extensions = extensions; params->extensions = extensions;

8
pc/session_description.h
View File

@ -291,10 +291,6 @@ class MediaContentDescription {
virtual MediaContentDescription* CloneInternal() const = 0; virtual MediaContentDescription* CloneInternal() const = 0;
}; };
// TODO(bugs.webrtc.org/8620): Remove this alias once downstream projects have
// updated.
using ContentDescription = MediaContentDescription;
template <class C> template <class C>
class MediaContentDescriptionImpl : public MediaContentDescription { class MediaContentDescriptionImpl : public MediaContentDescription {
public: public:
@ -429,10 +425,6 @@ enum class MediaProtocolType {
// https://tools.ietf.org/html/rfc4960 // https://tools.ietf.org/html/rfc4960
}; };
// TODO(bugs.webrtc.org/8620): Remove once downstream projects have updated.
constexpr MediaProtocolType NS_JINGLE_RTP = MediaProtocolType::kRtp;
constexpr MediaProtocolType NS_JINGLE_DRAFT_SCTP = MediaProtocolType::kSctp;
// Represents a session description section. Most information about the section // Represents a session description section. Most information about the section
// is stored in the description, which is a subclass of MediaContentDescription. // is stored in the description, which is a subclass of MediaContentDescription.
// Owns the description. // Owns the description.