zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unneeded and incorrect logic for 32-bit time wrap around

Browse Source 
The RTCP next send time has used a 64-bit type since
https://webrtc-codereview.appspot.com/678011 (2012).

Bug: None
Change-Id: Ie570e9b82d71d9d8d56af91478741226d73e090e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/198541
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32868}
This commit is contained in:
Niels Möller
2020-12-21 11:43:10 +01:00
committed by Commit Bot
parent 8649e49d10
commit 1f2209d28c
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/rtp_rtcp/source/rtcp_sender.cc
View File

@ -435,14 +435,7 @@ bool RTCPSender::TimeToSendRTCPReport(bool sendKeyframeBeforeRTP) const {
now += RTCP_SEND_BEFORE_KEY_FRAME_MS;
}
if (now >= next_time_to_send_rtcp_) {
return true;
} else if (now < 0x0000ffff &&
next_time_to_send_rtcp_ > 0xffff0000) { // 65 sec margin
// wrap
return true;
}
return false;
return now >= next_time_to_send_rtcp_;
}
std::unique_ptr<rtcp::RtcpPacket> RTCPSender::BuildSR(const RtcpContext& ctx) {