zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change ReceiveStatistics to implement RtpPacketSinkInterface, part 1

Browse Source 
Add new method OnRtpPacket, but leave
ReceiveStatisticsImpl::IncomingPacket and most of the implementation
unchanged. Deleting the old method and converting implementation from
RTPHeader to RtpPacketreceived is planned for a followup, after
downstream code is updated.

Bug: webrtc:7135, webrtc:8016
Change-Id: I697ec12804618859f8d69415622d1b957e1d0847
Reviewed-on: https://webrtc-review.googlesource.com/100104
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24889}
This commit is contained in:
Niels Möller
2018-09-14 08:26:32 +02:00
committed by Commit Bot
parent 2fbb83b16b
commit 1f3206cca4
17 changed files with 214 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
modules/rtp_rtcp/include/receive_statistics.h
View File

@ -14,6 +14,7 @@
#include <map>
#include <vector>
#include "call/rtp_packet_sink_interface.h"
#include "modules/include/module.h"
#include "modules/include/module_common_types.h"
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@ -48,28 +49,22 @@ class StreamStatistician {
virtual uint32_t BitrateReceived() const = 0;
};
class ReceiveStatistics : public ReceiveStatisticsProvider {
class ReceiveStatistics : public ReceiveStatisticsProvider,
public RtpPacketSinkInterface {
public:
~ReceiveStatistics() override = default;
static ReceiveStatistics* Create(Clock* clock);
// Updates the receive statistics with this packet.
// TODO(bugs.webrtc.org/8016): Deprecated. Delete as soon as
// downstream code is updated to use OnRtpPacket.
RTC_DEPRECATED
virtual void IncomingPacket(const RTPHeader& rtp_header,
size_t packet_length) = 0;
// TODO(nisse): Wrapper for backwards compatibility. Delete as soon as
// downstream callers are updated.
RTC_DEPRECATED
void IncomingPacket(const RTPHeader& rtp_header,
size_t packet_length,
bool retransmitted) {
IncomingPacket(rtp_header, packet_length);
}
// Increment counter for number of FEC packets received.
virtual void FecPacketReceived(const RTPHeader& header,
size_t packet_length) = 0;
virtual void FecPacketReceived(const RtpPacketReceived& packet) = 0;
// Returns a pointer to the statistician of an ssrc.
virtual StreamStatistician* GetStatistician(uint32_t ssrc) const = 0;