Changing echo_path_size_bytes() to static, and using size_t rather than int. This is recommended by Chromium:

http://www.chromium.org/developers/coding-style

Fixing a few compile warnings.
Review URL: http://webrtc-codereview.appspot.com/81001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@228 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
ajm@google.com
2011-07-18 18:03:01 +00:00
parent 1e34241426
commit 22e65158bd
8 changed files with 56 additions and 47 deletions

View File

@ -11,6 +11,8 @@
#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_MAIN_INTERFACE_AUDIO_PROCESSING_H_
#define WEBRTC_MODULES_AUDIO_PROCESSING_MAIN_INTERFACE_AUDIO_PROCESSING_H_
#include <stddef.h> // size_t
#include "typedefs.h"
#include "module.h"
@ -357,18 +359,24 @@ class EchoControlMobile {
virtual bool is_comfort_noise_enabled() const = 0;
// A typical use case is to initialize the component with an echo path from a
// previous call. The echo path is retrieved using |GetEchoPath()| typically
// at the end of a call. The data can then be stored for later use as
// initializer, using |SetEchoPath()|.
// previous call. The echo path is retrieved using |GetEchoPath()|, typically
// at the end of a call. The data can then be stored for later use as an
// initializer before the next call, using |SetEchoPath()|.
//
// Controlling the echo path this way requires the data |size_bytes| to match
// the internal echo path size. This size can be acquired using
// |echo_path_size_bytes()|. |SetEchoPath()| causes an entire reset, worth
// noting if it is to be called during an ongoing call. It is possible that
// version incompatibilities may result in a stored echo path of the
// incorrect size. In this case, the stored path should be discarded.
virtual int SetEchoPath(const void* echo_path, int size_bytes) = 0;
virtual int GetEchoPath(void* echo_path, int size_bytes) const = 0;
virtual const int echo_path_size_bytes() const = 0;
// noting if it is to be called during an ongoing call.
//
// It is possible that version incompatibilities may result in a stored echo
// path of the incorrect size. In this case, the stored path should be
// discarded.
virtual int SetEchoPath(const void* echo_path, size_t size_bytes) = 0;
virtual int GetEchoPath(void* echo_path, size_t size_bytes) const = 0;
// The returned path size is guaranteed not to change for the lifetime of
// the application.
static size_t echo_path_size_bytes();
protected:
virtual ~EchoControlMobile() {};