zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CodeHealth: Python3 migration for tools_webrtc/mb/

Browse Source 
This CL includes:
* set Pylint to 2.7 in tools_webrtc/mb/PRESUBMIT.py
* fix some style warnings caused by scripts in tools_webrtc/mb/
* pass skip_shebang_check=True within tools_webrtc/mb/PRESUBMIT.py

Bug: chromium:1262287, chromium:1262352
Change-Id: Iae4f111942d724db6a7f4585c97a7c26c1e6ccc0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/239660
Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35477}
This commit is contained in:
Nidhi Jaju
2021-12-02 10:38:50 +00:00
committed by WebRTC LUCI CQ
parent 73d0774b6b
commit 2394977f74
3 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tools_webrtc/mb/PRESUBMIT.py
View File

@ -11,12 +11,28 @@ def _CommonChecks(input_api, output_api):
results = []
# Run Pylint over the files in the directory.
pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api)
pylint_checks = input_api.canned_checks.GetPylint(
input_api,
output_api,
version='2.7',
# Disabling certain python3-specific warnings until the conversion
# is complete.
disabled_warnings=[
'super-with-arguments',
'raise-missing-from',
'useless-object-inheritance',
'arguments-differ',
],
)
results.extend(input_api.RunTests(pylint_checks))
# Run the MB unittests.
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
input_api, output_api, '.', [ r'^.+_unittest\.py$']))
input_api,
output_api,
'.',
[ r'^.+_unittest\.py$'],
skip_shebang_check=True))
# Validate the format of the mb_config.pyl file.
cmd = [input_api.python_executable, 'mb.py', 'validate']