Refactor legacy FrameBuffer to use EncodedImageBuffer::Realloc

Preparation for deleting VCMEncodedFrame::VerifyAndAllocate and
EncodedImage::Allocate.

Bug: webrtc:9378
Change-Id: If7c16061962bbd58c3e7d5720189854e00a3d7bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154570
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29339}
This commit is contained in:
Niels Möller
2019-09-30 10:18:16 +02:00
committed by Commit Bot
parent fbf75a7891
commit 2449d7aa78
4 changed files with 18 additions and 3 deletions

View File

@ -101,7 +101,7 @@ VCMFrameBufferEnum VCMFrameBuffer::InsertPacket(const VCMPacket& packet,
uint32_t requiredSizeBytes =
size() + packet.sizeBytes +
(packet.insertStartCode ? kH264StartCodeLengthBytes : 0);
if (requiredSizeBytes >= capacity()) {
if (requiredSizeBytes > capacity()) {
const uint8_t* prevBuffer = data();
const uint32_t increments =
requiredSizeBytes / kBufferIncStepSizeBytes +
@ -112,7 +112,15 @@ VCMFrameBufferEnum VCMFrameBuffer::InsertPacket(const VCMPacket& packet,
"big.";
return kSizeError;
}
VerifyAndAllocate(newSize);
if (data() == nullptr) {
encoded_image_buffer_ = EncodedImageBuffer::Create(newSize);
SetEncodedData(encoded_image_buffer_);
set_size(0);
} else {
RTC_CHECK(encoded_image_buffer_ != nullptr);
RTC_DCHECK_EQ(encoded_image_buffer_->data(), data());
encoded_image_buffer_->Realloc(newSize);
}
_sessionInfo.UpdateDataPointers(prevBuffer, data());
}