zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Demote RtpStreamReceiverController AddSink/RemoveSink to private

Browse Source 
Bug: webrtc:7135, webrtc:10198, webrtc:14256
Change-Id: I47dc9034170b1868ad442d36c74c5380964b476b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267827
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37457}
This commit is contained in:
Niels Möller
2022-07-06 10:02:23 +02:00
committed by WebRTC LUCI CQ
parent ed66b77e58
commit 25e268ae0f
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
call/rtp_stream_receiver_controller.cc
View File

@ -31,9 +31,7 @@ RtpStreamReceiverController::Receiver::Receiver(
}
RtpStreamReceiverController::Receiver::~Receiver() {
// Don't require return value > 0, since for RTX we currently may
// have multiple Receiver objects with the same sink.
// TODO(nisse): Consider adding a DCHECK when RtxReceiveStream is wired up.
// This may fail, if corresponding AddSink in the constructor failed.
controller_->RemoveSink(sink_);
}
@ -58,7 +56,7 @@ bool RtpStreamReceiverController::AddSink(uint32_t ssrc,
return demuxer_.AddSink(ssrc, sink);
}
size_t RtpStreamReceiverController::RemoveSink(
bool RtpStreamReceiverController::RemoveSink(
const RtpPacketSinkInterface* sink) {
RTC_DCHECK_RUN_ON(&demuxer_sequence_);
return demuxer_.RemoveSink(sink);