Remove ReceiveCodec() getters from VideoCodingModule.
The getters are not used and the implementation cannot be guaranteed to return a correct value except when called synchronously from the decoding thread while decoding. The methods as is imply that the implementation needs to offer some sort of synchronization, and that's not desirable. BUG=webrtc:7328 R=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2741853008 . Cr-Commit-Position: refs/heads/master@{#17233}
This commit is contained in:
@ -220,14 +220,6 @@ class VideoCodingModuleImpl : public VideoCodingModule {
|
||||
return receiver_.Decode(maxWaitTimeMs);
|
||||
}
|
||||
|
||||
int32_t ReceiveCodec(VideoCodec* currentReceiveCodec) const override {
|
||||
return receiver_.ReceiveCodec(currentReceiveCodec);
|
||||
}
|
||||
|
||||
VideoCodecType ReceiveCodec() const override {
|
||||
return receiver_.ReceiveCodec();
|
||||
}
|
||||
|
||||
int32_t IncomingPacket(const uint8_t* incomingPayload,
|
||||
size_t payloadLength,
|
||||
const WebRtcRTPHeader& rtpInfo) override {
|
||||
|
||||
Reference in New Issue
Block a user