zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

adopt absl::string_view in logging/

Browse Source 
Bug: webrtc:13579
Change-Id: Ibc5fa7842d52321d61cc4cdd4770635af737ddff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267170
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37533}
This commit is contained in:
Ali Tofigh
2022-07-15 00:44:02 +02:00
committed by WebRTC LUCI CQ
parent 90133b3d3f
commit 277766f55e
20 changed files with 100 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
logging/rtc_event_log/encoder/delta_encoding.cc
View File

@ -16,6 +16,7 @@
#include <utility>
#include "absl/memory/memory.h"
#include "absl/strings/string_view.h"
#include "logging/rtc_event_log/encoder/bit_writer.h"
#include "logging/rtc_event_log/encoder/var_int.h"
#include "rtc_base/bit_buffer.h"
@ -554,7 +555,7 @@ class FixedLengthDeltaDecoder final {
// bitstream. Note that this does NOT imply that stream is valid, and will
// be decoded successfully. It DOES imply that all other decoder classes
// will fail to decode this input, though.
static bool IsSuitableDecoderFor(const std::string& input);
static bool IsSuitableDecoderFor(absl::string_view input);
// Assuming that `input` is the result of fixed-size delta-encoding
// that took place with the same value to `base` and over `num_of_deltas`
@ -562,7 +563,7 @@ class FixedLengthDeltaDecoder final {
// If an error occurs (can happen if `input` is corrupt), an empty
// vector will be returned.
static std::vector<absl::optional<uint64_t>> DecodeDeltas(
const std::string& input,
absl::string_view input,
absl::optional<uint64_t> base,
size_t num_of_deltas);
@ -579,7 +580,7 @@ class FixedLengthDeltaDecoder final {
// the entire stream is free of error. Rather, only the encoding header is
// examined and guaranteed.
static std::unique_ptr<FixedLengthDeltaDecoder> Create(
const std::string& input,
absl::string_view input,
absl::optional<uint64_t> base,
size_t num_of_deltas);
@ -624,7 +625,7 @@ class FixedLengthDeltaDecoder final {
const size_t num_of_deltas_;
};
bool FixedLengthDeltaDecoder::IsSuitableDecoderFor(const std::string& input) {
bool FixedLengthDeltaDecoder::IsSuitableDecoderFor(absl::string_view input) {
BitstreamReader reader(input);
uint64_t encoding_type_bits = reader.ReadBits(kBitsInHeaderForEncodingType);
if (!reader.Ok()) {
@ -639,7 +640,7 @@ bool FixedLengthDeltaDecoder::IsSuitableDecoderFor(const std::string& input) {
}
std::vector<absl::optional<uint64_t>> FixedLengthDeltaDecoder::DecodeDeltas(
const std::string& input,
absl::string_view input,
absl::optional<uint64_t> base,
size_t num_of_deltas) {
auto decoder = FixedLengthDeltaDecoder::Create(input, base, num_of_deltas);
@ -651,7 +652,7 @@ std::vector<absl::optional<uint64_t>> FixedLengthDeltaDecoder::DecodeDeltas(
}
std::unique_ptr<FixedLengthDeltaDecoder> FixedLengthDeltaDecoder::Create(
const std::string& input,
absl::string_view input,
absl::optional<uint64_t> base,
size_t num_of_deltas) {
BitstreamReader reader(input);
@ -804,7 +805,7 @@ std::string EncodeDeltas(absl::optional<uint64_t> base,
}
std::vector<absl::optional<uint64_t>> DecodeDeltas(
const std::string& input,
absl::string_view input,
absl::optional<uint64_t> base,
size_t num_of_deltas) {
RTC_DCHECK_GT(num_of_deltas, 0); // Allows empty vector to indicate error.