zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "[Stats] Cleanup: Remove unimplemented metrics and obsolete TODOs."

Browse Source 
This is a reland of commit 626f87d90501fd8d7a4ea071686cd8befd0d430c

Original change's description:
> [Stats] Cleanup: Remove unimplemented metrics and obsolete TODOs.
>
> In preparation for the spec moving closer to PR, let's not have
> placeholder metrics not implemented.
>
> Bug: webrtc:14167
> Change-Id: If4688ef85b57f88154d490186b306b30414874e4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265383
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#37205}

Bug: webrtc:14167
Change-Id: Ifdc37e7a48fea516c727c06d2f510780386cb204
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265805
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#37215}
This commit is contained in:
Henrik Boström
2022-06-13 10:23:28 +02:00
committed by WebRTC LUCI CQ
parent fc3e7249b1
commit 2843bbc96d
3 changed files with 30 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
stats/rtcstats_objects.cc
View File

@ -191,7 +191,6 @@ WEBRTC_RTCSTATS_IMPL(RTCIceCandidatePairStats, RTCStats, "candidate-pair",
&priority,
&nominated,
&writable,
&readable,
&packets_sent,
&packets_received,
&bytes_sent,
@ -204,12 +203,7 @@ WEBRTC_RTCSTATS_IMPL(RTCIceCandidatePairStats, RTCStats, "candidate-pair",
&requests_sent,
&responses_received,
&responses_sent,
&retransmissions_received,
&retransmissions_sent,
&consent_requests_received,
&consent_requests_sent,
&consent_responses_received,
&consent_responses_sent,
&packets_discarded_on_send,
&bytes_discarded_on_send)
// clang-format on
@ -228,7 +222,6 @@ RTCIceCandidatePairStats::RTCIceCandidatePairStats(std::string&& id,
priority("priority"),
nominated("nominated"),
writable("writable"),
readable("readable"),
packets_sent("packetsSent"),
packets_received("packetsReceived"),
bytes_sent("bytesSent"),
@ -241,12 +234,7 @@ RTCIceCandidatePairStats::RTCIceCandidatePairStats(std::string&& id,
requests_sent("requestsSent"),
responses_received("responsesReceived"),
responses_sent("responsesSent"),
retransmissions_received("retransmissionsReceived"),
retransmissions_sent("retransmissionsSent"),
consent_requests_received("consentRequestsReceived"),
consent_requests_sent("consentRequestsSent"),
consent_responses_received("consentResponsesReceived"),
consent_responses_sent("consentResponsesSent"),
packets_discarded_on_send("packetsDiscardedOnSend"),
bytes_discarded_on_send("bytesDiscardedOnSend") {}
@ -260,7 +248,6 @@ RTCIceCandidatePairStats::RTCIceCandidatePairStats(
priority(other.priority),
nominated(other.nominated),
writable(other.writable),
readable(other.readable),
packets_sent(other.packets_sent),
packets_received(other.packets_received),
bytes_sent(other.bytes_sent),
@ -273,12 +260,7 @@ RTCIceCandidatePairStats::RTCIceCandidatePairStats(
requests_sent(other.requests_sent),
responses_received(other.responses_received),
responses_sent(other.responses_sent),
retransmissions_received(other.retransmissions_received),
retransmissions_sent(other.retransmissions_sent),
consent_requests_received(other.consent_requests_received),
consent_requests_sent(other.consent_requests_sent),
consent_responses_received(other.consent_responses_received),
consent_responses_sent(other.consent_responses_sent),
packets_discarded_on_send(other.packets_discarded_on_send),
bytes_discarded_on_send(other.bytes_discarded_on_send) {}
@ -412,15 +394,11 @@ WEBRTC_RTCSTATS_IMPL(RTCMediaStreamTrackStats, RTCStats, "track",
&jitter_buffer_emitted_count,
&frame_width,
&frame_height,
&frames_per_second,
&frames_sent,
&huge_frames_sent,
&frames_received,
&frames_decoded,
&frames_dropped,
&frames_corrupted,
&partial_frames_lost,
&full_frames_lost,
&audio_level,
&total_audio_energy,
&echo_return_loss,
@ -465,15 +443,11 @@ RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(std::string&& id,
jitter_buffer_emitted_count("jitterBufferEmittedCount"),
frame_width("frameWidth"),
frame_height("frameHeight"),
frames_per_second("framesPerSecond"),
frames_sent("framesSent"),
huge_frames_sent("hugeFramesSent"),
frames_received("framesReceived"),
frames_decoded("framesDecoded"),
frames_dropped("framesDropped"),
frames_corrupted("framesCorrupted"),
partial_frames_lost("partialFramesLost"),
full_frames_lost("fullFramesLost"),
audio_level("audioLevel"),
total_audio_energy("totalAudioEnergy"),
echo_return_loss("echoReturnLoss"),
@ -521,15 +495,11 @@ RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
jitter_buffer_emitted_count(other.jitter_buffer_emitted_count),
frame_width(other.frame_width),
frame_height(other.frame_height),
frames_per_second(other.frames_per_second),
frames_sent(other.frames_sent),
huge_frames_sent(other.huge_frames_sent),
frames_received(other.frames_received),
frames_decoded(other.frames_decoded),
frames_dropped(other.frames_dropped),
frames_corrupted(other.frames_corrupted),
partial_frames_lost(other.partial_frames_lost),
full_frames_lost(other.full_frames_lost),
audio_level(other.audio_level),
total_audio_energy(other.total_audio_energy),
echo_return_loss(other.echo_return_loss),
@ -688,20 +658,9 @@ WEBRTC_RTCSTATS_IMPL(
&audio_level,
&total_audio_energy,
&total_samples_duration,
&round_trip_time,
&packets_repaired,
&burst_packets_lost,
&burst_packets_discarded,
&burst_loss_count,
&burst_discard_count,
&burst_loss_rate,
&burst_discard_rate,
&gap_loss_rate,
&gap_discard_rate,
&frames_received,
&frame_width,
&frame_height,
&frame_bit_depth,
&frames_per_second,
&frames_decoded,
&key_frames_decoded,
@ -747,20 +706,9 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(std::string&& id,
audio_level("audioLevel"),
total_audio_energy("totalAudioEnergy"),
total_samples_duration("totalSamplesDuration"),
round_trip_time("roundTripTime"),
packets_repaired("packetsRepaired"),
burst_packets_lost("burstPacketsLost"),
burst_packets_discarded("burstPacketsDiscarded"),
burst_loss_count("burstLossCount"),
burst_discard_count("burstDiscardCount"),
burst_loss_rate("burstLossRate"),
burst_discard_rate("burstDiscardRate"),
gap_loss_rate("gapLossRate"),
gap_discard_rate("gapDiscardRate"),
frames_received("framesReceived"),
frame_width("frameWidth"),
frame_height("frameHeight"),
frame_bit_depth("frameBitDepth"),
frames_per_second("framesPerSecond"),
frames_decoded("framesDecoded"),
key_frames_decoded("keyFramesDecoded"),
@ -803,20 +751,9 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(
audio_level(other.audio_level),
total_audio_energy(other.total_audio_energy),
total_samples_duration(other.total_samples_duration),
round_trip_time(other.round_trip_time),
packets_repaired(other.packets_repaired),
burst_packets_lost(other.burst_packets_lost),
burst_packets_discarded(other.burst_packets_discarded),
burst_loss_count(other.burst_loss_count),
burst_discard_count(other.burst_discard_count),
burst_loss_rate(other.burst_loss_rate),
burst_discard_rate(other.burst_discard_rate),
gap_loss_rate(other.gap_loss_rate),
gap_discard_rate(other.gap_discard_rate),
frames_received(other.frames_received),
frame_width(other.frame_width),
frame_height(other.frame_height),
frame_bit_depth(other.frame_bit_depth),
frames_per_second(other.frames_per_second),
frames_decoded(other.frames_decoded),
key_frames_decoded(other.key_frames_decoded),