From 28fb04de62233d285d4b36a2f3fc2cbf0d16733b Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Wed, 5 Oct 2022 20:49:55 +0200 Subject: [PATCH] metrics: remove WebRTC.PeerConnection.IceServers.* which have shown that 32 is a reasonably safe limit and informed https://github.com/w3c/webrtc-pc/pull/2679/ BUG=webrtc:13265,chromium:1360224 Change-Id: I63155653862e4c12720b8655c51ed5f3bdc742f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277804 Reviewed-by: Johannes Kron Reviewed-by: Harald Alvestrand Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/main@{#38339} --- pc/peer_connection.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pc/peer_connection.cc b/pc/peer_connection.cc index e05a2b730e..02cafc542d 100644 --- a/pc/peer_connection.cc +++ b/pc/peer_connection.cc @@ -668,10 +668,6 @@ RTCError PeerConnection::Initialize( }, delay_ms); - // Record the number of configured ICE servers for all connections. - RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.PeerConnection.IceServers.Configured", - configuration_.servers.size(), 0, 31, 32); - return RTCError::OK(); } @@ -1985,10 +1981,6 @@ void PeerConnection::ReportFirstConnectUsageMetrics() { RTC_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.ProvisionalAnswer", pranswer, kProvisionalAnswerMax); - // Record the number of configured ICE servers for connected connections. - RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.PeerConnection.IceServers.Connected", - configuration_.servers.size(), 0, 31, 32); - // Record the number of valid / invalid ice-ufrag. We do allow certain // non-spec ice-char for backward-compat reasons. At this point we know // that the ufrag/pwd consists of a valid ice-char or one of the four