zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix clang style errors in rtp_rtcp and dependant targets

Browse Source 
Mark functions with override instead of virtual.
Add explicit non-trivial constructors/assign operators/destructors.
Define them in .cc files instead of inlining
use auto* instead of auto when deduced type is raw pointer

Bug: webrtc:163
Change-Id: I4d8a05d6a64fcc2ca16d02c5fcf9488fda832a6d
Reviewed-on: https://webrtc-review.googlesource.com/48781
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21927}
This commit is contained in:
Danil Chapovalov
2018-02-07 09:38:31 +01:00
committed by Commit Bot
parent 740f8e72df
commit 2a5ce2bcf8
43 changed files with 189 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/remote_bitrate_estimator/test/bwe_test_logging.cc
View File

@ -34,6 +34,9 @@ static std::string ToString(uint32_t v) {
return ss.str();
}
Logging::ThreadState::ThreadState() = default;
Logging::ThreadState::~ThreadState() = default;
Logging::Context::Context(uint32_t name, int64_t timestamp_ms, bool enabled) {
Logging::GetInstance()->PushState(ToString(name), timestamp_ms, enabled);
}
@ -205,6 +208,8 @@ Logging::Logging()
: thread_map_() {
}
Logging::~Logging() = default;
Logging::State::State() : tag(""), timestamp_ms(0), enabled(true) {}
Logging::State::State(const std::string& tag, int64_t timestamp_ms,

3
modules/remote_bitrate_estimator/test/bwe_test_logging.h
View File

@ -331,12 +331,15 @@ class Logging {
bool enabled;
};
struct ThreadState {
ThreadState();
~ThreadState();
State global_state;
std::stack<State> stack;
};
typedef std::map<uint32_t, ThreadState> ThreadMap;
Logging();
~Logging();
void PushState(const std::string& append_to_tag, int64_t timestamp_ms,
bool enabled);
void PopState();