zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix clang style errors in rtp_rtcp and dependant targets

Browse Source 
Mark functions with override instead of virtual.
Add explicit non-trivial constructors/assign operators/destructors.
Define them in .cc files instead of inlining
use auto* instead of auto when deduced type is raw pointer

Bug: webrtc:163
Change-Id: I4d8a05d6a64fcc2ca16d02c5fcf9488fda832a6d
Reviewed-on: https://webrtc-review.googlesource.com/48781
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21927}
This commit is contained in:
Danil Chapovalov
2018-02-07 09:38:31 +01:00
committed by Commit Bot
parent 740f8e72df
commit 2a5ce2bcf8
43 changed files with 189 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/rtp_rtcp/source/rtp_format_h264.h
View File

@ -30,7 +30,7 @@ class RtpPacketizerH264 : public RtpPacketizer {
size_t last_packet_reduction_len,
H264PacketizationMode packetization_mode);
virtual ~RtpPacketizerH264();
~RtpPacketizerH264() override;
size_t SetPayloadData(const uint8_t* payload_data,
size_t payload_size,
@ -49,6 +49,7 @@ class RtpPacketizerH264 : public RtpPacketizer {
struct Fragment {
Fragment(const uint8_t* buffer, size_t length);
explicit Fragment(const Fragment& fragment);
~Fragment();
const uint8_t* buffer = nullptr;
size_t length = 0;
std::unique_ptr<rtc::Buffer> tmp_buffer;
@ -100,7 +101,7 @@ class RtpPacketizerH264 : public RtpPacketizer {
class RtpDepacketizerH264 : public RtpDepacketizer {
public:
RtpDepacketizerH264();
virtual ~RtpDepacketizerH264();
~RtpDepacketizerH264() override;
bool Parse(ParsedPayload* parsed_payload,
const uint8_t* payload_data,