zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge cpu_features build targets into //system_wrappers.

Browse Source 
Before this CL, functions declared in cpu_features_wrapper.h where
not defined in the same build target, causing brittle builds that
might fail at link time if the binary was not depending on
//system_wrappers (the target with the definitions), violating [1].

This CL moves everything into //system_wrappers and also moves
cpu_features_wrapper.h definitions from C to C++ (in order to be able
to add the definitions to a C++ build target like //system_wrappers).

[1] - https://webrtc.googlesource.com/src/+/refs/heads/master/style-guide.md#h-cc-pairs

Bug: None
Change-Id: I5a0009cddb17206b19f2a71eeba722faacc4bcae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183380
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32039}
This commit is contained in:
Mirko Bonadei
2020-09-05 21:55:35 +02:00
committed by Commit Bot
parent 7f557b46c4
commit 2b242d8fba
16 changed files with 24 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_processing/agc2/BUILD.gn
View File

@ -153,7 +153,7 @@ rtc_library("noise_level_estimator") {
"../../../common_audio/third_party/ooura:fft_size_128",
"../../../rtc_base:checks",
"../../../rtc_base:macromagic",
"../../../system_wrappers:cpu_features_api",
"../../../system_wrappers",
]
configs += [ "..:apm_debug_dump" ]

4
modules/audio_processing/agc2/rnn_vad/BUILD.gn
View File

@ -48,7 +48,7 @@ rtc_library("rnn_vad") {
"../../../../rtc_base:checks",
"../../../../rtc_base:rtc_base_approved",
"../../../../rtc_base/system:arch",
"../../../../system_wrappers:cpu_features_api",
"../../../../system_wrappers",
"../../utility:pffft_wrapper",
"//third_party/rnnoise:rnn_vad",
]
@ -67,7 +67,7 @@ if (rtc_include_tests) {
"../../../../api:scoped_refptr",
"../../../../rtc_base:checks",
"../../../../rtc_base/system:arch",
"../../../../system_wrappers:cpu_features_api",
"../../../../system_wrappers",
"../../../../test:fileutils",
"../../../../test:test_support",
]