Merge cpu_features build targets into //system_wrappers.
Before this CL, functions declared in cpu_features_wrapper.h where not defined in the same build target, causing brittle builds that might fail at link time if the binary was not depending on //system_wrappers (the target with the definitions), violating [1]. This CL moves everything into //system_wrappers and also moves cpu_features_wrapper.h definitions from C to C++ (in order to be able to add the definitions to a C++ build target like //system_wrappers). [1] - https://webrtc.googlesource.com/src/+/refs/heads/master/style-guide.md#h-cc-pairs Bug: None Change-Id: I5a0009cddb17206b19f2a71eeba722faacc4bcae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183380 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32039}
This commit is contained in:
committed by
Commit Bot
parent
7f557b46c4
commit
2b242d8fba
@ -37,7 +37,7 @@ rtc_library("video_processing") {
|
||||
"../../rtc_base:checks",
|
||||
"../../rtc_base:rtc_base_approved",
|
||||
"../../rtc_base/system:arch",
|
||||
"../../system_wrappers:cpu_features_api",
|
||||
"../../system_wrappers",
|
||||
"//third_party/libyuv",
|
||||
]
|
||||
if (build_video_processing_sse2) {
|
||||
|
||||
Reference in New Issue
Block a user