zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed default value for the duration of the echo in echocanceller 3

Browse Source 
BUG=webrtc:7519

Review-Url: https://codereview.webrtc.org/2971683002
Cr-Commit-Position: refs/heads/master@{#18887}
This commit is contained in:
peah
2017-07-04 04:33:11 -07:00
committed by Commit Bot
parent 0d7f04daa0
commit 2c3161c86e
4 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_processing/aec3/echo_canceller3.cc
View File

@ -334,7 +334,7 @@ std::string EchoCanceller3::ToString(
bool EchoCanceller3::Validate( bool EchoCanceller3::Validate(
const AudioProcessing::Config::EchoCanceller3& config) { const AudioProcessing::Config::EchoCanceller3& config) {
return (config.echo_decay >= 0.f && config.echo_decay < 1.f); return true;
} }
void EchoCanceller3::EmptyRenderQueue() { void EchoCanceller3::EmptyRenderQueue() {

10
webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc
View File

@ -684,17 +684,7 @@ TEST(EchoCanceller3Messaging, EchoLeakage) {
TEST(EchoCanceller3, ConfigValidation) { TEST(EchoCanceller3, ConfigValidation) {
AudioProcessing::Config::EchoCanceller3 config; AudioProcessing::Config::EchoCanceller3 config;
config.echo_decay = 0.f;
EXPECT_TRUE(EchoCanceller3::Validate(config)); EXPECT_TRUE(EchoCanceller3::Validate(config));
config.echo_decay = 0.9f;
EXPECT_TRUE(EchoCanceller3::Validate(config));
config.echo_decay = -0.1f;
EXPECT_FALSE(EchoCanceller3::Validate(config));
config.echo_decay = 1.0f;
EXPECT_FALSE(EchoCanceller3::Validate(config));
config.echo_decay = 1.1f;
EXPECT_FALSE(EchoCanceller3::Validate(config));
} }
#if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)

2
webrtc/modules/audio_processing/aec3/echo_remover.cc
View File

@ -104,7 +104,7 @@ EchoRemoverImpl::EchoRemoverImpl(
suppression_gain_(optimization_), suppression_gain_(optimization_),
cng_(optimization_), cng_(optimization_),
suppression_filter_(sample_rate_hz_), suppression_filter_(sample_rate_hz_),
aec_state_(config.echo_decay) { aec_state_(0.8f) {
RTC_DCHECK(ValidFullBandRate(sample_rate_hz)); RTC_DCHECK(ValidFullBandRate(sample_rate_hz));
} }

1
webrtc/modules/audio_processing/include/audio_processing.h
View File

@ -268,7 +268,6 @@ class AudioProcessing : public rtc::RefCountInterface {
// does not yet have the desired behavior. // does not yet have the desired behavior.
struct EchoCanceller3 { struct EchoCanceller3 {
bool enabled = false; bool enabled = false;
float echo_decay = 0.f;
} echo_canceller3; } echo_canceller3;
// Enables the next generation AGC functionality. This feature replaces the // Enables the next generation AGC functionality. This feature replaces the